Add details of error to the "Unexpected git error!" message

ConnectionMaster · Sep 10, 2019 · d27aa5b · d27aa5b
1 parent 11c25c7
commit d27aa5b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/common/lib/dependabot/pull_request_creator/github.rb b/common/lib/dependabot/pull_request_creator/github.rb
@@ -61,7 +61,9 @@ def branch_exists?(name)
         raise(RepoNotFound, source.url) unless repo_exists?
 
         retrying ||= false
-        raise "Unexpected git error!" if retrying
+
+        msg = "Unexpected git error!\n\n#{e.cause&.class}: #{e.cause&.message}"
+        raise msg if retrying
 
         retrying = true
         retry

diff --git a/common/spec/dependabot/pull_request_creator/github_spec.rb b/common/spec/dependabot/pull_request_creator/github_spec.rb
@@ -280,7 +280,7 @@
       end
 
       it "raises a normal error" do
-        expect { creator.create }.to raise_error("Unexpected git error!")
+        expect { creator.create }.to raise_error(/Unexpected git error!/)
       end
     end
-Original file line number
+Diff line change
@@ Expand Up / @@ -280,7 +280,7 @@ @@
           end
           it "raises a normal error" do
-            expect { creator.create }.to raise_error("Unexpected git error!")
+            expect { creator.create }.to raise_error(/Unexpected git error!/)
           end
         end
@@ Expand Down @@