[ServiceDesk] Empty HTTP error when using create_customer_request() atlassian-api#1136

Author: gonchik

atlassian/service_desk.py

@@ -148,14 +148,13 @@ def create_customer_request(
         if request_participants:
             data["requestParticipants"] = request_participants
 
-        param_map = {"headers": self.experimental_headers}
+        if not isinstance(values_dict, (dict, str)):
+            raise TypeError("values_dict must be a dictionary or JSON string")
 
-        if isinstance(values_dict, dict):
-            param_map["json"] = data
-        elif isinstance(values_dict, str):
-            param_map["data"] = data
-
-        return self.post("rest/servicedeskapi/request", **param_map)
+        # The create-request endpoint is a stable JSON endpoint.  Passing the
+        # complete payload through ``json`` avoids form/data coercion and keeps
+        # nested request field values intact on both Cloud and Server.
+        return self.post("rest/servicedeskapi/request", json=data, headers=self.default_headers)
 
     def get_customer_request_status(self, issue_id_or_key):
         """

docs/service_desk.rst

@@ -60,7 +60,8 @@ The Request actions
 
 .. code-block:: python
 
-    # Create customer request
+    # Create customer request. ``values_dict`` must contain the fields required
+    # by the request type (for example, summary and description).
     sd.create_customer_request(service_desk_id, request_type_id, values_dict, raise_on_behalf_of=None, request_participants=None)
 
     # Get customer request by ID

tests/test_service_desk_request.py

@@ -0,0 +1,31 @@
+from unittest.mock import patch
+
+import pytest
+
+from atlassian import ServiceDesk
+
+
+def test_create_customer_request_sends_json_with_standard_headers():
+    service_desk = ServiceDesk("https://example.atlassian.net")
+    values = {"summary": "A request", "description": "Details", "priority": "low"}
+
+    with patch.object(service_desk, "post", return_value={"issueKey": "HELP-1"}) as post:
+        result = service_desk.create_customer_request("10", "25", values)
+
+    assert result == {"issueKey": "HELP-1"}
+    post.assert_called_once_with(
+        "rest/servicedeskapi/request",
+        json={
+            "serviceDeskId": "10",
+            "requestTypeId": "25",
+            "requestFieldValues": values,
+        },
+        headers=service_desk.default_headers,
+    )
+
+
+def test_create_customer_request_rejects_non_json_field_values():
+    service_desk = ServiceDesk("https://example.atlassian.net")
+
+    with pytest.raises(TypeError, match="values_dict must be"):
+        service_desk.create_customer_request("10", "25", ["summary"])