Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finger peint library update #3

Merged
merged 8 commits into from
Aug 15, 2018
Merged

Conversation

vikas0309
Copy link

@vikas0309 vikas0309 commented Aug 10, 2018

This PR is for Reseting mFingerprintIdentify to reset to its initial value, so it again checks at the hardware level.

@@ -114,6 +114,11 @@ public void isSensorAvailable(final Promise promise) {
}
}

@ReactMethod
public void isFingerPrintIdentifyRefresh() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this function is to reset mFingerprintIdentify then please use relevant name for the function.
isFingerPrintIdentifyRefresh - Doesn't suit as per the functionality.

Copy link

@udaisshekhawat udaisshekhawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments ..

Copy link

@udaisshekhawat udaisshekhawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now ..

@vikas0309 vikas0309 merged commit d189837 into master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants