Skip to content

Commit

Permalink
Yahoo Ads Bid Adapter: Fix to not set bidResponse vastUrl field with …
Browse files Browse the repository at this point in the history
…bid nurl value. (prebid#12128)
  • Loading branch information
zach-bowman authored Sep 9, 2024
1 parent 4d9c15a commit 0a7627e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
4 changes: 0 additions & 4 deletions modules/yahooAdsBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -660,10 +660,6 @@ export const spec = {
bidResponse.mediaType = VIDEO;
bidResponse.meta.mediaType = VIDEO;
bidResponse.vastXml = bid.adm;

if (bid.nurl) {
bidResponse.vastUrl = bid.nurl;
};
}

if (deepAccess(bidderRequest, 'mediaTypes.video.context') === 'outstream' && !bidderRequest.renderer && bidResponse.mediaType === VIDEO) {
Expand Down
9 changes: 0 additions & 9 deletions test/spec/modules/yahooAdsBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1496,15 +1496,6 @@ describe('Yahoo Advertising Bid Adapter:', () => {
expect(response[0].mediaType).to.equal('video');
})

it('should insert video VAST win notification into vastUrl', () => {
const { serverResponse, bidderRequest } = generateResponseMock('video', 'vast');
const response = spec.interpretResponse(serverResponse, {bidderRequest});
expect(response[0].ad).to.be.undefined;
expect(response[0].vastUrl).to.equal('https://yahoo.com?event=adAttempt');
expect(response[0].vastXml).to.equal('<VAST></VAST>');
expect(response[0].mediaType).to.equal('video');
})

describe('wrapped in video players for display inventory', () => {
beforeEach(() => {
config.setConfig({
Expand Down

0 comments on commit 0a7627e

Please sign in to comment.