feat: Automatically create branch and handle empty repos #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d cleanup Remove finalizer logic from GitDestination controller and implement ReconcileWorkers method in WorkerManager to handle orphaned worker cleanup. This approach simplifies lifecycle management and handles edge cases like namespace deletion or forced deletion more gracefully. Changes: - Remove finalizer constant, handleDeletion method, and finalizer logic - Add WorkerManager.ReconcileWorkers() for orphaned worker detection - Use GitDestination UID for work directories to ensure uniqueness - Update RBAC to remove gitdestinations/finalizers permission - Update e2e tests to validate GitDestination branch handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get the setup dev experience at a better level. Also having a better resonsibility definition per resource.