Housekeeping: Markdownlint #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UI test coverage: 79.31% 🤷♂️ Did not change |
jayjayjpg
approved these changes
Feb 24, 2023
docs/architecture-decision-records/20220121-conduit-plugin-architecture.md
Outdated
Show resolved
Hide resolved
maha-hajja
reviewed
Feb 24, 2023
maha-hajja
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the CI action https://github.com/DavidAnson/markdownlint-cli2-action that executes https://github.com/DavidAnson/markdownlint when markdown files are updated. Settings are stored in
.markdownlint.ymland taken mostly from here with some changes (i.e. line length 120, tables excluded from line length checks, hard tabs are allowed ingocode blocks, Conduit needs to be written with an uppercase C).The CI action lints all markdown files (i.e. files that end with
.md) exceptLICENSE.md, anything inpkg/web/openapi, anything inui/node_modulesand markdown files in.github.I also ran
markdown-cli2-fixthat fixed most of the issues, the rest were fixed manually.Quick checks: