feat: add ecdysis to Conduit CLI by raulb · Pull Request #1983 · ConduitIO/conduit

raulb · 2024-11-19T14:37:38Z

Description

Fixes #1981

Send config to init and utilize its tags
Use feat: add support to nested structs ecdysis#1 rather than the local version at the moment.
Use feat: Add parsing configuration decorator ecdysis#3

⚠️ Remove support for pipelines.exit-on-error (announced here)

Quick checks

I have followed the Code Guidelines.
There is no other pull request for the same update/change.
I have written unit tests.
I have made sure that the PR is of reasonable size and can be easily reviewed.

…raul/add-ecdysis

cmd/conduit/internal/config.go

cmd/conduit/root/root.go

cmd/conduit/root/pipelines/init.go

cmd/conduit/root/root_test.go

…raul/add-ecdysis

cmd/conduit/root/root.go

cmd/conduit/root/root_test.go

cmd/conduit/root/root.go

raulb added 11 commits November 15, 2024 18:12

structure pkg

16ce659

refactor to reutilize global flags

d54599f

update root with global flags

34dd04c

Merge branch 'main' into raul/add-ecdysis

60bc6fe

update new init

2abe751

Merge branch 'raul/add-ecdysis' of github.com:ConduitIO/conduit into …

637845d

…raul/add-ecdysis

finish migrating commands

d191bb4

update which ones are general flags

790e005

Merge branch 'main' into raul/add-ecdysis

b4a714d

fix lint

077ea75

Merge branch 'raul/add-ecdysis' of github.com:ConduitIO/conduit into …

eddb1a1

…raul/add-ecdysis

raulb marked this pull request as ready for review November 21, 2024 15:34

raulb requested a review from a team as a code owner November 21, 2024 15:34

raulb added 2 commits November 21, 2024 16:35

remove TODO

4fc6f5b

hide completion for now

c00924b

raulb marked this pull request as draft November 21, 2024 16:28

raulb added 9 commits November 25, 2024 18:15

feature complete

00f153b

fix CI

29793c2

Merge branch 'main' into raul/add-ecdysis

656dc3f

fix conduit init

2e16578

fix flags on pipelines init

f6717b3

Merge branch 'raul/add-ecdysis' of github.com:ConduitIO/conduit into …

324f8e6

…raul/add-ecdysis

fix pipelines init

f727f42

uses simplified version of generator and file

f6061b6

Merge branch 'main' into raul/add-ecdysis

e15b1cf

raulb marked this pull request as ready for review November 26, 2024 12:28

raulb added 2 commits November 26, 2024 13:39

fix init

b13f469

fix removed config

16a5656

hariso reviewed Nov 26, 2024

View reviewed changes

cmd/conduit/internal/config.go Outdated Show resolved Hide resolved

hariso reviewed Nov 26, 2024

View reviewed changes

cmd/conduit/root/root.go Outdated Show resolved Hide resolved

hariso reviewed Nov 27, 2024

View reviewed changes

cmd/conduit/root/pipelines/init.go Outdated Show resolved Hide resolved

hariso reviewed Nov 27, 2024

View reviewed changes

cmd/conduit/root/root_test.go Outdated Show resolved Hide resolved

test in progress

62f20cf

raulb mentioned this pull request Dec 2, 2024

feat: add support to nested structs ConduitIO/ecdysis#1

Merged

raulb added 12 commits December 2, 2024 16:11

fixes

243fcb9

parsing config wip

a7a24d5

update root using decorator

be3c3ee

fix conduit init

7b62025

simplifies

b9c8f63

remove unnecessary check

53cdeec

defaultSource or defaultDestination only if empty

7fb3f46

merge

cf9143c

uses latest changes on ecdysis

4e625e6

Merge branch 'main' into raul/add-ecdysis

a5dc198

fetch latest ecdysis

fad4b78

Merge branch 'raul/add-ecdysis' of github.com:ConduitIO/conduit into …

03fbbbf

…raul/add-ecdysis

raulb requested a review from hariso December 17, 2024 21:07

raulb self-assigned this Dec 17, 2024

hariso reviewed Dec 18, 2024

View reviewed changes

cmd/conduit/root/root.go Outdated Show resolved Hide resolved

hariso reviewed Dec 18, 2024

View reviewed changes

cmd/conduit/root/root.go Show resolved Hide resolved

hariso reviewed Dec 18, 2024

View reviewed changes

cmd/conduit/root/root_test.go Outdated Show resolved Hide resolved

cmd/conduit/root/root.go Show resolved Hide resolved

cmd/conduit/root/root.go Outdated Show resolved Hide resolved

cmd/conduit/root/root.go Show resolved Hide resolved

raulb mentioned this pull request Dec 18, 2024

feat: Be able to set flag default values from a struct ConduitIO/ecdysis#4

Open

hariso approved these changes Dec 18, 2024

View reviewed changes

raulb added 2 commits December 18, 2024 15:45

update latest ecdysis and root test

370a638

chore: use ecdysis 0.0.1

f586fc3

raulb merged commit 5360931 into main Dec 18, 2024
3 checks passed

raulb deleted the raul/add-ecdysis branch December 18, 2024 15:31

raulb mentioned this pull request Dec 18, 2024

Epic: +CLI -UI #1911

Closed

40 tasks

raulb mentioned this pull request Jan 27, 2025

changelog: Warn removal of exitOnError of flag on Conduit v.0.13 ConduitIO/conduit-site#219

Closed

lyuboxa mentioned this pull request Jan 28, 2025

exit pipeline error flag is removed in v0.13 ConduitIO/conduit-operator#48

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add ecdysis to Conduit CLI#1983

feat: add ecdysis to Conduit CLI#1983
raulb merged 42 commits intomainfrom
raul/add-ecdysis

raulb commented Nov 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

raulb commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Quick checks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

raulb commented Nov 19, 2024 •

edited

Loading