retrofit: mint infrastructure-helpers capability (3 REQs / 6 methods)#297
Merged
rubenvdlinde merged 1 commit intoMay 25, 2026
Conversation
New capability covers three cross-cutting helper classes that were flagged Bucket 2b (no owning capability) by the 2026-05-24 coverage scan: - SlugGenerator (2 methods) — URL-safe slug grammar + transform pipeline + validation - UserAttributeResolver (2 methods) — Nextcloud user attribute lookup + 5 string-comparison operators - RequestDataExtractor (2 methods) — tile + placement form data extraction from IRequest Per the SKILL's bias-toward-extend rule, considered extending dashboards / conditional-visibility / tiles+widgets — but the helpers' shared shape (stateless, no persistence, reusable across capabilities) is itself the spec, so a thin new capability with a clear Scope section keeps each owning capability focused on domain behaviour. Ghost change: archive/2026-05-24-retrofit-infrastructure-helpers. Refs #292
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 436/436 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 18:23 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Reverse-Spec
Mints a new `infrastructure-helpers` capability covering 6 methods across 3 cross-cutting helper classes flagged Bucket 2b by the 2026-05-24 coverage scan (no owning capability).
Ghost change: `archive/2026-05-24-retrofit-infrastructure-helpers` (archived in this PR).
What this PR does
Why a new capability rather than `--extend`?
Per ADR-003 and the SKILL's bias-toward-`--extend` rule, considered alternatives:
The new capability includes a `## Scope` section that prevents drift: future helpers that DO fit a domain capability should land there, not here.
What this PR does NOT do
Review focus
Source: `openspec/coverage-report.md` generated 2026-05-24
Cluster: infrastructure-helpers (Bucket 2b)
Refs #292