retrofit: reverse-spec dashboards helpers (4 REQs / 9 methods)#295
Open
rubenvdlinde wants to merge 1 commit into
Open
retrofit: reverse-spec dashboards helpers (4 REQs / 9 methods)#295rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Draft REQ-DASH-038..041 from observed behaviour of two helper classes extracted from DashboardApiController for testability: - DashboardRequestValidator (4 methods) — permission gating + parameter resolution + partial-update null-filtering - ResponseHelper (5 methods) — JSON envelope shape, status code contract, exception-to-error translation (ADR-005 no message leak) Ghost change: archive/2026-05-24-retrofit-dashboards. Refs #292
rubenvdlinde
added
openspec
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 436/436 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 18:14 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Reverse-Spec
Describes observed behavior of 9 methods under
dashboards(two controller-helper classes) as 4 new REQs.Ghost change:
archive/2026-05-24-retrofit-dashboards(archived in this PR).What this PR does
retrofit_extensions: [REQ-DASH-038..041]on the dashboards spec frontmatter:[x]— code already exists)@spec openspec/changes/archive/2026-05-24-retrofit-dashboards/tasks.md#task-Nopenspec/specs/dashboards/spec.md)What this PR does NOT do
ResponseHelper::error()nullable-logger silent-swallow is documented in REQ-DASH-041 Notes (TODO for future tightening)ResponseHelper::serializeList()precondition (every element must implementJsonSerializable) is documented, not defended-againstReview focus
Source:
openspec/coverage-report.mdgenerated 2026-05-24Cluster: dashboards (Bucket 2a)
Refs #292