Repository navigation
fix(example-sets): Noor's economie lesson gives the board's short reason, and H4b is invited to the mentor talks - #1890
Draft
rubenvdlinde wants to merge 1 commit into
Draft
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…son, and H4b is invited to the mentor talks The vo set seeds one conference invitation per invited H4b pupil, as the live listener writes them, so the guardian task and the Berichten board have a row to read. The economie lesson's reason reads "Niet in lokaal 1.08".
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 110/110 | |||
| npm | ✅ | ✅ 747/747 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | 🚨 NO VERDICT — enabled but never ran | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-09 05:03 UTC
Download the full PDF report from the workflow artifacts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things Noor Bakker's pupil boards show that the vo set's data lacked (portal proof run 3).
What changes
scripts/example-sets/vo.py(andlib/Settings/profiles/vo.jsonregenerated):conference-invitationper invited H4b pupil, asConferenceInvitationswrites them on a live save and po.py already seeds them: booked for the two classmates with a time, open for the other 25, Noor among them ("Kies een tijd voor het mentorgesprek" on Berichten). The schema is appended to the set's order, so no uuid moves (8047 to 8074 objects).OpenSpec:
openspec/changes/vaartveld-pupil-story-data. Its "Not in this change" lists the fields the boards need that only FIX-L can add (teacher names and salutation, the grade's component label, the homework subject, CKV/LO band words, pupil-facing messages and invitation).Verification
python3 scripts/example-sets/vo.py --check: exit 0.SecondarySchoolExampleSetTest(15 tests; the newtestEveryH4bPupilIsInvitedToTheMentorTalksand the stricter reason assertion both fail on development's profile),ExampleSetDescriptorContractTest,StudentTimetableTest,PortalPublicIndexTest,DemoDatesTest: green.🤖 Generated with Claude Code