Skip to content

fix(portal): Vaartveld's public pages follow their boards - #1889

Draft
rubenvdlinde wants to merge 2 commits into
developmentfrom
feat/vaartveld-public-pages-follow-the-boards
Draft

rubenvdlinde wants to merge 2 commits into
developmentfrom
feat/vaartveld-public-pages-follow-the-boards

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Vaartveld College's public pages follow their boards (portal proof run 3, school-design vaartveld/preview Home, Zoeken, Artikel, Contentpagina). Declarations only, in lib/Settings/portals/vo.json, on the portaliq options merged this week.

What changes

  • portal.breadcrumb: "page".
  • Home: the hero says "vmbo-t, havo en vwo"; "Kom kennismaken" with a chevron, "Lees wat er speelt op school" as a text link; plain "Direct regelen" icons with the board's icon names; agenda rows without links; "Ons onderwijs" in three columns (Vmbo-t, Havo, Vwo). The Onderwijs page names vmbo-t too.
  • Zoeken: the board's intro; nlCatalogue with kindFacet: "Soort", labelHidden, pageSize: 6, facetDisplay: {Leerjaar: select}, types: [news, document]; six more public news items about last school year's toetsweken (all older than the home's six, so the home does not change); publicIndex.documents: the eleven documents of the board (five toetsroosters, PTA 4 havo, three letters to parents, the toetsweek rules, the school guide) in portaliq's public index item shape with the facets Soort, Afdeling and Leerjaar.
  • Artikel: kindLabel, sectionHref: /zoeken, sectionLabel: Nieuws en documenten; the light "Kom je ook?" card (tone: light, note), "Om alvast te lezen" and "Meer nieuws" in the right column; the Informatieavond body in the board's order (capitalised facts, "De vier profielen", the closing paragraph).
  • Contentpagina: action "Ziek melden" inside the callout (the separate button goes), rowHeaders, "18 jaar of ouder?" and "Is uw kind lang ziek?" as plain cards under the side list.

OpenSpec: openspec/changes/vaartveld-public-pages-follow-the-boards.

Depends on / asks of FIX-L

  • The documents reach the search page only once PortalPublicIndex reads publicIndex.documents (and moves their dates with the load week). Until then the search shows the seven toetsweek news items.
  • breadcrumb must join ExamplePortalProvisioner::FILLABLE for a fresh load to write it.

Decisions

  • The hero follows the board ("vmbo-t, havo en vwo"), although the set's classes are havo and vwo only.
  • 13 of the 18 search items are authored to match the board's counts (Nieuws 7, Toetsroosters en PTA 6, Brieven aan ouders 3, Schoolgids en regels 2), grounded in the set's toetsweek dates and classes. No board text was changed to make a count fit, so "toetsweek" finds 17 (the PTA's board text lacks the word). New documents carry no file size and no link: no file ships with the set.
  • No "Voor wie" facet: the vo board filters by Soort, Afdeling, Leerjaar and Periode, not by audience.

Not in this PR (portaliq)

  • "Is uw kind lang ziek?" draws its link as a button (nlAlert.action); the board has a text link.
  • No photo place in an article; "De vier profielen" is a plain list, not cards; no "Periode" facet.

Verification

  • PHPUnit VaartveldPublicPagesTest (4 tests, new; all 4 fail on development's vo.json), ExamplePortalDeclarationsTest (side-column assertion relaxed to "the link list comes first", so cards may follow it), ExamplePortalProvisionerTest, PortalPublicIndexTest, DemoDatesTest, PortalMessageContactsTest, SeedProfileServiceTest: all green.
  • Draft: the full check:strict and npm checks run once before ready.

🤖 Generated with Claude Code

Home names vmbo-t and draws its second action as a text link, the search
page filters by kind and declares the board's school documents, the article
carries its pill, section crumb and light side card, and the content page
holds its button inside the callout with two plain side cards.
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/learniq @ a811544

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-specs ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 110/110
npm ✅ ✅ 747/747
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit 🚨 NO VERDICT — enabled but never ran
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ⏭️

Quality workflow — 2026-10-09 05:02 UTC

Download the full PDF report from the workflow artifacts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant