Repository navigation
fix(portal): Vaartveld's public pages follow their boards - #1889
Draft
rubenvdlinde wants to merge 2 commits into
Draft
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
Home names vmbo-t and draws its second action as a text link, the search page filters by kind and declares the board's school documents, the article carries its pill, section crumb and light side card, and the content page holds its button inside the callout with two plain side cards.
…-public-pages-follow-the-boards
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 110/110 | |||
| npm | ✅ | ✅ 747/747 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | 🚨 NO VERDICT — enabled but never ran | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-09 05:02 UTC
Download the full PDF report from the workflow artifacts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vaartveld College's public pages follow their boards (portal proof run 3, school-design
vaartveld/previewHome, Zoeken, Artikel, Contentpagina). Declarations only, inlib/Settings/portals/vo.json, on the portaliq options merged this week.What changes
portal.breadcrumb: "page".nlCataloguewithkindFacet: "Soort",labelHidden,pageSize: 6,facetDisplay: {Leerjaar: select},types: [news, document]; six more public news items about last school year's toetsweken (all older than the home's six, so the home does not change);publicIndex.documents: the eleven documents of the board (five toetsroosters, PTA 4 havo, three letters to parents, the toetsweek rules, the school guide) in portaliq's public index item shape with the facets Soort, Afdeling and Leerjaar.kindLabel,sectionHref: /zoeken,sectionLabel: Nieuws en documenten; the light "Kom je ook?" card (tone: light,note), "Om alvast te lezen" and "Meer nieuws" in the right column; the Informatieavond body in the board's order (capitalised facts, "De vier profielen", the closing paragraph).action"Ziek melden" inside the callout (the separate button goes),rowHeaders, "18 jaar of ouder?" and "Is uw kind lang ziek?" as plain cards under the side list.OpenSpec:
openspec/changes/vaartveld-public-pages-follow-the-boards.Depends on / asks of FIX-L
PortalPublicIndexreadspublicIndex.documents(and moves their dates with the load week). Until then the search shows the seven toetsweek news items.breadcrumbmust joinExamplePortalProvisioner::FILLABLEfor a fresh load to write it.Decisions
Not in this PR (portaliq)
nlAlert.action); the board has a text link.Verification
VaartveldPublicPagesTest(4 tests, new; all 4 fail on development's vo.json),ExamplePortalDeclarationsTest(side-column assertion relaxed to "the link list comes first", so cards may follow it),ExamplePortalProvisionerTest,PortalPublicIndexTest,DemoDatesTest,PortalMessageContactsTest,SeedProfileServiceTest: all green.🤖 Generated with Claude Code