Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make governance app choose a different name for zip file #96

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Make governance app choose a different name for zip file #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile.common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ endif
@echo "python3 -m ledgerblue.deleteApp $(COMMON_DELETE_PARAMS)" >> uninstall.sh
@chmod +x uninstall.sh
@chmod +x bin/app.hex
@zip -r concordium-ledger-app-$(APPVERSION)-$(TARGET_DEVICE)-$(TARGET_VERSION).zip \
@zip -r $(APP_FILE_NAME)-$(APPVERSION)-$(TARGET_DEVICE)-$(TARGET_VERSION).zip \
licenses \
install.bat \
loadcertificate.bat \
Expand All @@ -158,7 +158,7 @@ endif
@rm -f uninstall.sh
@rm -f signed_app.apdu
@echo
@echo "Application was successfully signed and packaged to concordium-ledger-app-$(APPVERSION)-$(TARGET_DEVICE)-$(TARGET_VERSION).zip"
@echo "Application was successfully signed and packaged to $(APP_FILE_NAME)-$(APPVERSION)-$(TARGET_DEVICE)-$(TARGET_VERSION).zip"

fail_release_no_public_key:
$(error A public key must set as LEDGER_PUBLIC_KEY)
Expand Down
2 changes: 2 additions & 0 deletions Makefile.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ endif
# Main app configuration
APPNAME = "Concordium"

APP_FILE_NAME = concordium-ledger-app

# Version must be no greater than 99.99.999, otherwise
# extra memory must be allocated in menu.c.
APPVERSION_MAJOR=4
Expand Down
2 changes: 2 additions & 0 deletions governance-app/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ endif
# Main app configuration
APPNAME = CCDGovernance

APP_FILE_NAME = concordium-governance-ledger-app

# Version must be no greater than 99.99.999, otherwise
# extra memory must be allocated in menu.c.
APPVERSION_MAJOR=1
Expand Down