Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for timeout parameters transaction #90

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Add support for timeout parameters transaction #90

merged 6 commits into from
Sep 19, 2023

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Sep 7, 2023

Purpose

Add support for timeout parameters transaction.

Changes

  • Added the new governance transaction.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

shjortConcordium
shjortConcordium reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@shjortConcordium shjortConcordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Can't run it atm though)

Base automatically changed from governance-app to main September 19, 2023 08:09
@orhoj orhoj assigned shjortConcordium and unassigned orhoj Sep 19, 2023
@orhoj orhoj merged commit 6c26a92 into main Sep 19, 2023
@orhoj orhoj deleted the sign-timeout-parameters branch September 19, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees

@shjortConcordium shjortConcordium

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium