numbers can be big now!

Conan-Kudo · Jul 13, 2023 · 019dcf9 · 019dcf9
1 parent a9c4918
commit 019dcf9
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,8 @@
+July 13, 2023: released 2.2.2
+ - fix a not-likely but potetially real string overflow from my year-2000
+   (yes, the irony!) assumption that integers won't possibly be bigger than
+   the size of a 32 bit number.
+
 October 2nd, 2021: released 2.2.1
  - minor build improvements from Reiner Herrmann (thanks!)
  - keywords in desktop file (also thanks Reiner!)

diff --git a/icebreaker.c b/icebreaker.c
@@ -163,7 +163,7 @@ int main(int argc,char** argv)
 	int level=0;
 	ScoreSheet levelscore;
 	long totalscore=0;
-	char windowtitle[38];
+	char windowtitle[39];
 	LevelExitType levelresult;
 	int newuser=false;
 	int rc=0;
@@ -206,13 +206,13 @@ int main(int argc,char** argv)
 		switch (options.difficulty)
 		{
 			case NORMAL:
-				snprintf(windowtitle,38,"IceBreaker -- Level %d",level);
+				snprintf(windowtitle,39,"IceBreaker -- Level %d",level);
 			break;
 			case HARD:
-				snprintf(windowtitle,38,"IceBreaker -- Level %d (Hard)",level);
+				snprintf(windowtitle,39,"IceBreaker -- Level %d (Hard)",level);
 			break;
 			case EASY:
-				snprintf(windowtitle,38,"IceBreaker -- Level %d (Easy)",level);
+				snprintf(windowtitle,39,"IceBreaker -- Level %d (Easy)",level);
 			break;
 		}			
 		drawtitlebar(windowtitle);

diff --git a/icebreaker.h b/icebreaker.h
@@ -29,10 +29,10 @@
 /************************************************************************/
 /* Versions and so forth -- you probably shouldn't change this. */
 
-#define VERSION 2.2.1
+#define VERSION 2.2.2
 #define VERMAJOR 2
 #define VERMINOR 2
-#define VERSUB 1
+#define VERSUB 2
 
 #ifndef DEVELRELEASE
 	#define DEVELRELEASE VERMINOR & 1

diff --git a/icebreaker.spec b/icebreaker.spec
@@ -1,5 +1,5 @@
 Name:       icebreaker
-Version:    2.2.1
+Version:    2.2.2
 Release:    1
 Summary:    An addictive action-puzzle game involving bouncing penguins
 %define     isprerelease 0
@@ -61,6 +61,9 @@ cp metainfo.xml ${RPM_BUILD_ROOT}%{_datadir}/metainfo/org.mattdm.icebreaker.meta
 
 
 %changelog
+* Thu Jul 13 2023 Matthew Miller <mattdm@mattdm.org> - 2.2.2-1
+- fix some really dumb stuff :)
+
 * Sun Oct  2 2021 Matthew Miller <mattdm@mattdm.org> - 2.2.1-1
 - minor build improvements via PR from reinerh