run snclient as snclient user on linux

[BlackIkeEagle]

See: #272

[sni]

This looks great and i think we definitely should do this.
I will do some tests hopefully during the next days.

[sni]

i am wondering if the sudo changes are actually required for something? Sudo is not used except in the tests so far. And if it's only used during testing, i don't think it should be part of the packaging.
What do you think?

[BlackIkeEagle]

Do you mean the addition of the sudoers file with Defaults:snclient !requiretty ? This comes from experience on Almalinux where we could not properly run custom scripts via snclient.

The hard dependency on sudo might be changed to a opt-depend I guess.

[sni]

ah, didn't see there is a dependency on sudo. There is one for alpine but ex. not for deb or rpm. Does it make sense to add it for all of them?

[BlackIkeEagle]

Ah, I forgot then if it is not there in the deb and rpm. But on second thought sudo can be an optdepend perfectly fine, and if doas or other privilege escalation stuff is confirmed working that could be added as well?

[sni]

well, personally i'd prefer not having anything sudo related in the "base" packages here since it is kinda out of scope. The snclient itself does not use sudo. Sure, you can use it in external commands, but so you can with any other command.

[BlackIkeEagle]

Ah oops, will rebase then, without sudo related stuff

[sni]

great, thanks. Could you please also remove the sudoers/snclient? I think it's more confusing then helping and if you use sudo in your setup, you have to roll out a sudo config anyway.

[BlackIkeEagle]

The rebase should have all traces of sudo removed if I did not miss anything

[sni]

Looks good. Thanks for all the work. I'll wait till after the next release to merge this, so we can properly announce this change.