gatekeep #34
Merged
gatekeep #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costowell
requested changes
Oct 12, 2025
costowell
requested changes
Oct 18, 2025
Contributor
costowell
left a comment
costowell
left a comment
There was a problem hiding this comment.
Just a little more polish and it should be good to go!
costowell
requested changes
Oct 19, 2025
Contributor
costowell
left a comment
costowell
left a comment
There was a problem hiding this comment.
Oops one last thing after talking to you
BigSpaceships
requested changes
Nov 3, 2025
Contributor
|
Tested actual functionality and it seems to work 👍 |
|
You should document VOTE_TOKEN in the README |
goosenotduck
requested changes
Nov 3, 2025
goosenotduck
left a comment
goosenotduck
left a comment
There was a problem hiding this comment.
Tested locally, all functional under my test cases:
- User passes gatekeep and can vote
- User fails gatekeep and cannot vote
- User fails gatekeep and is waived and is able to vote
Please add documentation to README
Schtick: CONDITIONAL_URL should be VOTE_CONDITONAL_URL for consistency.
tallen42
requested changes
Nov 5, 2025
tallen42
approved these changes
Nov 6, 2025
costowell
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gatekeep requirements to follow ComputerScienceHouse/Constitution#260