Notifications Phase 1: Subscription #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinmatte
commented
Aug 15, 2019
| # OneSignal Config | ||
| ONESIGNAL_USER_AUTH_KEY = environ.get("PACKET_ONESIGNAL_USER_AUTH_KEY", None) | ||
| ONESIGNAL_APP_AUTH_KEY = environ.get("PACKET_ONESIGNAL_APP_AUTH_KEY", None) | ||
| ONESIGNAL_APP_ID = environ.get("PACKET_ONESIGNAL_APP_ID", "6eff123a-0852-4027-804e-723044756f00") |
Member
Author
There was a problem hiding this comment.
This is a test ID that only works on localhost:6969 for testing
Member
There was a problem hiding this comment.
You may want to note that in a line comment then. It'd help us track what is needed for local testing.
devinmatte
commented
Aug 15, 2019
|
|
||
| <!-- Push Notifications --> | ||
| <script src="https://cdn.onesignal.com/sdks/OneSignalSDK.js" async=""></script> | ||
| <script> |
Member
Author
There was a problem hiding this comment.
As much as possible from this will be moved into a notifications.js file in Phase 2
devinmatte
force-pushed
the
onesignal_notifications
branch
from
94d10c1 to
9945dfb
Compare
devinmatte
force-pushed
the
onesignal_notifications
branch
from
9945dfb to
ee28245
Compare
JoelEager
approved these changes
Aug 15, 2019
| # OneSignal Config | ||
| ONESIGNAL_USER_AUTH_KEY = environ.get("PACKET_ONESIGNAL_USER_AUTH_KEY", None) | ||
| ONESIGNAL_APP_AUTH_KEY = environ.get("PACKET_ONESIGNAL_APP_AUTH_KEY", None) | ||
| ONESIGNAL_APP_ID = environ.get("PACKET_ONESIGNAL_APP_ID", "6eff123a-0852-4027-804e-723044756f00") |
Member
There was a problem hiding this comment.
You may want to note that in a line comment then. It'd help us track what is needed for local testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to subscribe to notifications and store the subscriptions in our database