Setup prod/dev okd config #33
Conversation
| data: | ||
| DB_URL: mongodb://<user>:<password>@tide.csh.rit.edu/vote?ssl=true | ||
| NODE_ENV: <env> | ||
| REACT_APP_BASE_API_URL: https://vote.csh.rit.edu |
There was a problem hiding this comment.
For these values does the react app still just ignore this and pull from the .env for whatever reason? we probably need to fix that so that it actually will point to the dev service for dev
There was a problem hiding this comment.
Yeah I meant to ask you about that. Does dotenv get overridden by the actual environment? Looks like vote.cs.house is a wee bit broken, if I simulate loggint in as evals it's getting stuck. If flashes logged in and then goes back to redirecting.
There was a problem hiding this comment.
So the .env file was part of the boilerplate and I don't really know where it pulls it in off the top of my head but I could look into that at some point. When we tried to remove it completely the variables were "undefined", so I don't think it's getting the actual environment at all for some reason, but I'm not sure why
There was a problem hiding this comment.
Alright, I'm gonna switch to homework for the rest of today, but we'll need to fix that before we're ready for 1.0.0 I think. I've set the dev build to build off this branch, so we can do a bit more testing on OKD if we need.
|
I'm gonna separate out the linting from this PR and get it in develop separately so that we get linting in #31. |
This sets up the configs to allow running a develop vs main branch.
Also adds some more instructions for deployment, and helps prevent someone from accidentally creating votes in the prod collections.
Pre Merge Checklist:
Post Merge Checklist:
mainbranch