Skip to content

Cs footer branch #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Cs footer branch #83

wants to merge 10 commits into from

Conversation

@DanielZavala11
Copy link
Collaborator

issue #29 updated branch and links navigate to proper (existing) place

@minhngo3818 minhngo3818 added Frontend task relates to frontend CSS require using css Home-page homepage labels Sep 17, 2022
minhngo3818
minhngo3818 reviewed Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@minhngo3818 minhngo3818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be an major change in design for frontend in near future, so I don't review thoroughly css part. There is a naming issue for readability. On the other hand, you have done very well by adding scrolling feature. It's an enhancement for homepage.

@minhngo3818 minhngo3818 self-requested a review November 15, 2022 05:37
@minhngo3818

This comment was marked as outdated.

Sign in to view
@minhngo3818 minhngo3818 removed their request for review December 9, 2022 02:19
@minhngo3818 minhngo3818 mentioned this pull request Mar 8, 2023
Closed
@minhngo3818 minhngo3818 closed this Mar 8, 2023
@minhngo3818 minhngo3818 reopened this Mar 8, 2023
@minhngo3818 minhngo3818 closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minhngo3818 minhngo3818 minhngo3818 left review comments

Assignees

@DanielZavala11 DanielZavala11

Labels

CSS require using css Frontend task relates to frontend Home-page homepage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielZavala11 @minhngo3818