relocate frontend files and setup backend environment #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhngo3818
added
feature-request
minhngo3818
changed the title
|
Backend setup was completed. Awaiting for merging current PRs |
|
The current Node js ci does not pass due to non-relevant ci. Require updated version of ci to test both backend and frontend setup-backend-env is ready for a review ! |
|
Yeah looks like prettier is broken too |
KHVBui
requested changes
Aug 31, 2022
KHVBui
requested changes
Aug 31, 2022
KHVBui
reviewed
Aug 31, 2022
KHVBui
reviewed
Sep 2, 2022
- A default working-directory for the client and backend jobs was added (only works with "run" keyword) - cache-dependecy-path was added for client and backend jobs to make "uses" keyword work properly - Added comments for clarity
KHVBui
reviewed
Sep 2, 2022
KHVBui
reviewed
Sep 2, 2022
…w-for-backend-setup 63-Fixed broken workflow bc/ of refactor
|
All imports was changed into comment to prevent import errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR setup environment for backend development. We will use express.js as backend framework base on its simplicity and fast. mongoDB is used for database because our website stores non-relational data. Backend tasks including api, data schema, ...etc will be posted after merging this PR. The backend environment is inside backend folder.
To make frontend more maintainable, all pages including homepage, events, projects, resources will be located in client/src/pages. Some reusable components including search bar, footer, navbar, ...etc will be in client/src/components. The services folder is supposed for handling api services.
Notes: This PR is not ready because we need to modify workflow for frontend and add a new workflow for backend All current PRs must be merged before this PR.