Restructure "Resources", replace "Research" with "Readings" in Resources, and add dummy data for Resources #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updates Resource.js to reference Tutorials, Readings, and Organizations JS files instead of containing JSX itself. This improves compartmentalization and prevents us from making as many conflicting changes in Resource.js. |
|
Can you add more data to each tab? It would be nice when there are at least 10 items per tab in order to test upcoming features including pagination, filter, (sort and search). |
|
Resolve issue #14 |
|
Yeah I can add more data to each tab. |
KHVBui
added
not ready PR
KHVBui
force-pushed
the
kevin-bui-branch
branch
2 times, most recently
from
38382ba to
cdb344e
Compare
KHVBui
changed the title
KHVBui
force-pushed
the
kevin-bui-branch
branch
2 times, most recently
from
fd4d5ff to
caa479f
Compare
minhngo3818
reviewed
Aug 1, 2022
| import React from 'react'; | ||
| import './resources.css'; | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove a blank line
minhngo3818
approved these changes
Aug 1, 2022
|
Yeah I need to totally reset this with all the prettier and linter changes and make sure it's all cleanup before I'll merge |
JSX will be contained in individual files instead of directly in Resources for compartmentalization
-Includes 11 entries per section in order to test pagination in the future -Tutorials fields: id, title, description, url, tags -Readings fields: id, title, publicationDate, description, url, tags -Organizations fields: id, title, description, url, tags
KHVBui
force-pushed
the
kevin-bui-branch
branch
from
1abfc21 to
d825827
Compare
minhngo3818
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mappings for Resource's dummy data:
Tutorials: id, title, description, url, tags
Readings: id, title, publicationDate, description, url, tags
Organizations: id, title, description, url, tags