Skip to content

ProjectCard Implemented #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

codebysid
Copy link

A new component ProjectCard is implemented which is fetching the fake Data Model to render the Project Cards.
Some colors are also added in tailwind.config.js.
TailwindCSS ,PostCSS and autoprefixer are upgraded to the latest version.

@minhngo3818 minhngo3818 self-requested a review April 11, 2023 16:21
@minhngo3818 minhngo3818 added Frontend task relates to frontend Tailwind CSS styling in tailwind css labels Apr 13, 2023
Copy link
Collaborator

@minhngo3818 minhngo3818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of work to edit. Please address changes. Overall, it looks wonderful with the responsive cards!

@minhngo3818 minhngo3818 self-requested a review April 26, 2023 04:26
border-white
border-solid
w-10 h-10
rounded-2xl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rounded-2xl
rounded-full

@apply border
border-white
border-solid
w-10 h-10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
w-10 h-10
w-12 h-12

Copy link
Collaborator

@minhngo3818 minhngo3818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors for project status are missing in tailwind configs or not included. Please add them and address some suggestions

<ProjectCardImg />
</div>
<div className="flex flex-col gap-6">
<p className="text-2xl">{title}</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p className="text-2xl">{title}</p>
<p className="text-2xl font-bold">{title}</p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend task relates to frontend Tailwind CSS styling in tailwind css
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants