Skip to content

Introduce "install_logs.sh" #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Introduce "install_logs.sh" #48

wants to merge 4 commits into from

Conversation

mboisson
Copy link
Member

No description provided.

Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't really fix it :)
I think it's annoying to need to copy/paste a URL instead of seeing it directly on your terminal screen.

there'd be a couple solutions:

  1. use github's api to get the info from github if possible
  2. use sudo -iu ebuser git blame
  3. present "solution" with git config
  4. create a temporary bare clone where you can run git blame on

@mboisson
Copy link
Member Author

ok, I rolled back who_install.sh then, and instead introduced another script

@ccoulombe
Copy link
Contributor

I'd suggest keeping the old behavior, that is : having the answer in the terminal, and adding a link as extra.
Filtering by year makes the script almost instantaneous. We could add an argument to filter by 2017, 2020, or all ?

@mboisson
Copy link
Member Author

I think it's annoying to need to copy/paste a URL instead of seeing it directly on your terminal screen.

I just hold Command and click on the URL, nothing to copy/paste, it opens in the browser

@ccoulombe
Copy link
Contributor

The sorting can be fixed with: sort -rV -k4

@mboisson
Copy link
Member Author

The sorting can be fixed with: sort -rV -k4

uh ?

@ccoulombe
Copy link
Contributor

To sort decreasingly the dates, and show who installed it most recently first

@mboisson
Copy link
Member Author

To sort decreasingly the dates, and show who installed it most recently first

There's no such sorting in the new script

@mboisson mboisson changed the title Fix who installed Introduce "install_logs.sh" Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants