Bunch Example: Add Single e- Setup #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
component: examples
4 tasks
ax3l
force-pushed
the
topic-updateBunchIdSinglePart
branch
from
816f3e9 to
7fb7a3a
Compare
PrometheusPi
approved these changes
Jan 11, 2017
| * unit: meter */ | ||
| (PMACC_C_VECTOR_DIM(float_64, simDim, sigma_SI, 6.0e-6, 6.0e-6, 6.0e-6)) | ||
| ); /* struct GaussianCloudParam */ | ||
| return 0.0; |
There was a problem hiding this comment.
just for clarity could you write:
if( isStartCell )
return 1.0;
else
return 0.0;
There was a problem hiding this comment.
imho, that is a question of personal preference.
since they is no code obfuscating what is happening, I will keep it that way if we do not find something more to change along.
|
@PrometheusPi did it create the expected radiation signature for you in both cases (bunch vs. single e-)? |
|
@ax3l My run time test failed for both bunch and single particle when picongpu tried to write radiation data (hdf5). I will check - might be just my setup. |
Closed
|
@ax3l Please adjust the walltime in the |
|
@ax3l Due to the |
|
Run time test works as expected. |
Adds a single e- setup with the same center as the bunch's Gaussian cloud.
ax3l
force-pushed
the
topic-updateBunchIdSinglePart
branch
from
7fb7a3a to
9bd1c81
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1716: Adds a single e- setup with the same center as the bunch's Gaussian
cloud. Re-adds a single-particle radiation test which is less hard to maintain as the previous one.
Also adds a
particleIdto all particles in theBunchexample, since it isa) useful in that test and
b)
particleIds have not yet been covered by the compile suite and/or documented in examplesTo Do