-
Notifications
You must be signed in to change notification settings - Fork 25
Relion >= 3.1 offsets convention: _rlnOriginX(Y)Angst #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
9e5eb62
Simulation pixel_size default=1.0. Private/public Image.downsample to…
j-c-c 3a2a851
Fix gallery pixel_size
j-c-c 7688e41
Adopt Relion 3.1 offset convention (_rlnOriginX(Y)Angst). Default pix…
j-c-c 5737bd6
Require pixel_size for all ImageSource objects
j-c-c 94a556b
tox
j-c-c fc0a059
cleanup Simulation pixel_size behavior. Fix docstring. Add test.
j-c-c 2588e71
Resolve Errors and failing tests
j-c-c b4fc52c
Fix galleries
j-c-c e001c01
fix param in gallery
j-c-c 137ddd4
more rebase cleanup
j-c-c f740d88
Update Simulation pixel_size behavior. Warn on mismatch.
j-c-c 6ee4315
_populate_pixel_size. Handle mismatches. tests
j-c-c 8849024
Fix failing tests
j-c-c 2d00e25
pixel_size setter/getter.
j-c-c 099bb38
add offset tests
j-c-c 73fc3a8
test src.downsample.pixel_size == src.img.downsample.pixel_size
j-c-c 4cc1760
test downsample save.
j-c-c 1551aa4
Remove detector metadata after src.downsample
j-c-c edd10cb
Remove xfail and fix apply_sim_filters bug
j-c-c 2063e69
ArrayImageSource pixel_size logic. Testing.
j-c-c d987367
fix gallery
j-c-c 9ce428b
CoordinateSource pixel_size behavior. Testing
j-c-c 5d1219f
Add pixel_size docstring to MicrographSimulation
j-c-c 6a3e997
edit docstring
j-c-c b73a355
asnumpy
j-c-c 8a2cf4a
update docstring for required pixel_size
j-c-c 999199d
clean up _populate_pixel_size logic
j-c-c ef3a0c2
_projection_pixel_size. test projections and clean_images.
j-c-c 26c86c0
pop_metadata
j-c-c 72eb2ad
check_pixel_size_mismatch util function.
j-c-c fed43aa
tox
j-c-c 8deee0b
offsets stored in doubles. pixels stored as float.
j-c-c f89a5b5
remove strict
j-c-c 3dee8c3
pixel_size logic
j-c-c a9d2d41
update check_pixel_size
j-c-c fdeec0f
cast pixel_size as float correctly. Add test to check pixel_size is c…
j-c-c 341d44e
check for scalar pixel_size. Add test.
j-c-c a3c6f4a
change argument names
j-c-c f58eab7
Remove None default for CoordinateSource pixel_size
j-c-c 1bab70c
typos
j-c-c 4680fc0
clarifying pixel_size comment in Downsample xform
j-c-c 7d10379
update check_pixel_size warning message. fix broken test.
j-c-c 339fef0
fix gallery
j-c-c 2cea2fc
update extract_particles CLI
j-c-c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we are bypassing the standard
Image.downsamplemethod in order to keep thepixel_sizethe same. Why?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the time this generation pipeline is kicked off by requesting images the pixel_size has already been adjusted as an image attribute and in metadata in the ImageSource.downsample method. If we use
Image.downsamplehere the pixel size will get adjusted twice.