Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-2360 Execute action for an account with label "primary" if no account is mentioned #853

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

plxity
Copy link
Contributor

@plxity plxity commented Nov 13, 2024

Added a check to include account with label "primary" if multiple accounts with same entity exists.


Important

Prioritize 'primary' labeled accounts in Entity.ts execute() method when no account is specified, and add labels to ConnectionParams.

  • Behavior:
    • In Entity.ts, execute() now prioritizes accounts labeled 'primary' if no connectedAccountId is provided.
    • If no 'primary' account is found, defaults to the first account.
  • Types:
    • Add optional labels field to ConnectionParams in types.gen.ts.

This description was created by Ellipsis for 6e72c1a. It will automatically update as commits are pushed.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 8:25am

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6e72c1a in 51 seconds

More details
  • Looked at 47 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. js/src/sdk/models/Entity.ts:72
  • Draft comment:
    Add a check to ensure connectedAccounts.items is defined before accessing its length to avoid potential runtime errors.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. js/src/sdk/client/types.gen.ts:856
  • Draft comment:
    Ensure to handle cases where labels might be undefined to prevent potential runtime errors.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_QSUnkdP4ZPz52rdn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Nov 13, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11833368273/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11833368273/html-report/report.html

@plxity plxity merged commit a38c83c into master Nov 14, 2024
9 checks passed
@plxity plxity deleted the ENG-2360 branch November 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants