Eng 2359 #852
Eng 2359 #852
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 4311534 in 42 seconds
More details
- Looked at
69lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_6mTbZtsSAkmaRNIq
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
js/src/sdk/models/actions.spec.ts
Outdated
| @@ -22,11 +22,22 @@ describe("Apps class tests", () => { | |||
| }); | |||
|
|
|||
| it("should get a list of actions", async () => { | |||
There was a problem hiding this comment.
The test case for listing actions with shouldSearchInIntegratedApps is duplicated. Consider removing one of them to avoid redundancy.
| it("should get a list of actions", async () => { |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
Skipped PR review on c7fcebf because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9b44fdb in 13 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_NbYH8uB1skLT5nXK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
js/src/sdk/models/actions.ts
Outdated
| /** | ||
| * Should search in available apps only | ||
| */ | ||
| onlySearchAvailableApps?: boolean; |
There was a problem hiding this comment.
filterByAvailableApps
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 059ced9 in 33 seconds
More details
- Looked at
124lines of code in7files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. js/src/sdk/models/actions.ts:60
- Draft comment:
The PR description mentionsonlySearchAvailableApps, but the code usesfilterByAvailableApps. Ensure the PR description is updated to reflect the correct parameter name. - Reason this comment was not posted:
Comment did not seem useful.
2. js/src/frameworks/cloudflare.ts:56
- Draft comment:
The parameteronlySearchAvailableAppshas been renamed tofilterByAvailableApps. Ensure this change is consistently applied across all relevant files. - Reason this comment was not posted:
Confidence changes required:10%
The code changes involve renaming a parameter fromonlySearchAvailableAppstofilterByAvailableApps. This change is consistent across multiple files, ensuring uniformity in the codebase.
3. js/src/frameworks/langchain.ts:68
- Draft comment:
The parameteronlySearchAvailableAppshas been renamed tofilterByAvailableApps. Ensure this change is consistently applied across all relevant files. - Reason this comment was not posted:
Confidence changes required:10%
The code changes involve renaming a parameter fromonlySearchAvailableAppstofilterByAvailableApps. This change is consistent across multiple files, ensuring uniformity in the codebase.
4. js/src/frameworks/openai.ts:49
- Draft comment:
The parameteronlySearchAvailableAppshas been renamed tofilterByAvailableApps. Ensure this change is consistently applied across all relevant files. - Reason this comment was not posted:
Confidence changes required:10%
The code changes involve renaming a parameter fromonlySearchAvailableAppstofilterByAvailableApps. This change is consistent across multiple files, ensuring uniformity in the codebase.
5. js/src/frameworks/vercel.ts:54
- Draft comment:
The parameteronlySearchAvailableAppshas been renamed tofilterByAvailableApps. Ensure this change is consistently applied across all relevant files. - Reason this comment was not posted:
Confidence changes required:10%
The code changes involve renaming a parameter fromonlySearchAvailableAppstofilterByAvailableApps. This change is consistent across multiple files, ensuring uniformity in the codebase.
6. js/src/sdk/base.toolset.ts:132
- Draft comment:
The parameteronlySearchAvailableAppshas been renamed tofilterByAvailableApps. Ensure this change is consistently applied across all relevant files. - Reason this comment was not posted:
Confidence changes required:10%
The code changes involve renaming a parameter fromonlySearchAvailableAppstofilterByAvailableApps. This change is consistent across multiple files, ensuring uniformity in the codebase.
7. js/src/sdk/models/actions.spec.ts:32
- Draft comment:
The parameteronlySearchAvailableAppshas been renamed tofilterByAvailableApps. Ensure this change is consistently applied across all relevant files. - Reason this comment was not posted:
Confidence changes required:10%
The code changes involve renaming a parameter fromonlySearchAvailableAppstofilterByAvailableApps. This change is consistent across multiple files, ensuring uniformity in the codebase.
Workflow ID: wflow_j141lLg81bMh8dnI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 351fded in 13 seconds
More details
- Looked at
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/src/sdk/models/actions.ts:192
- Draft comment:
Consider providing a more descriptive error message to help users understand why bothfilterByAvailableAppsandappscannot be provided together. - Reason this comment was not posted:
Confidence changes required:50%
The error message should be more descriptive to help users understand the issue better.
Workflow ID: wflow_doZ7Qylk4c2iUBzv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
User can now search for actions across all the apps or also only in integrated applications using
onlySearchAvailableAppsparameterImportant
Adds
onlySearchAvailableAppsparameter to filter actions in integrated apps and updates related tests.onlySearchAvailableAppsparameter tolistmethod inActionsclass inactions.tsto filter actions in integrated apps.getToolsmethods inCloudflareToolSet,LangchainToolSet,OpenAIToolSet, andVercelAIToolSetclasses to supportonlySearchAvailableApps.actions.spec.tsto verifylistmethod retrieves actions from integrated apps whenonlySearchAvailableAppsis true.This description was created by
for 351fded. It will automatically update as commits are pushed.