Skip to content

Remove Debian 10 Product#12205

Merged
jan-cerny merged 9 commits into
ComplianceAsCode:masterfrom
Mab879:remove_deb10
Jul 24, 2024
Merged

Remove Debian 10 Product#12205
jan-cerny merged 9 commits into
ComplianceAsCode:masterfrom
Mab879:remove_deb10

Conversation

@Mab879
Copy link
Copy Markdown
Member

@Mab879 Mab879 commented Jul 22, 2024

Description:

Removal of Debian 10.

Rationale:

Closes #12111

@Mab879 Mab879 added the product-removal Issues or pull requests that relate to the removal of products. label Jul 22, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 22, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 22, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 22, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12205
This image was built from commit: e3135b5

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12205

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12205 make deploy-local

@Mab879 Mab879 force-pushed the remove_deb10 branch 5 times, most recently from c8a2547 to b167c32 Compare July 22, 2024 20:51
@Mab879 Mab879 marked this pull request as draft July 23, 2024 04:04
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 23, 2024
@Mab879
Copy link
Copy Markdown
Member Author

Mab879 commented Jul 23, 2024

Once approved and before merging we will need to remove the Debian 10 build job requirement.

Once this is merged then we should add the Debian 12 requirement back.

@Mab879 Mab879 marked this pull request as ready for review July 23, 2024 14:23
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 23, 2024
@jan-cerny jan-cerny self-assigned this Jul 24, 2024
jan-cerny
jan-cerny requested changes Jul 24, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove DEBIAN10 from build_product line 357.

@jan-cerny
Copy link
Copy Markdown
Collaborator

jan-cerny commented Jul 24, 2024

I have removed the Debian 10 branch build job requirement.

@Mab879 Mab879 requested a review from jan-cerny July 24, 2024 14:56
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Jul 24, 2024

Code Climate has analyzed commit e3135b5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit 929a9d2 into ComplianceAsCode:master Jul 24, 2024
@Mab879 Mab879 deleted the remove_deb10 branch July 24, 2024 17:45
@Mab879 Mab879 added the Highlight This PR/Issue should make it to the featured changelog. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels

Highlight This PR/Issue should make it to the featured changelog. product-removal Issues or pull requests that relate to the removal of products.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

[Product Removal Request] Debian 10

2 participants

@Mab879 @jan-cerny