Skip to content

fix: sheet is too small, or might be displayed on the wrong window #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 22, 2025
Merged

fix: sheet is too small, or might be displayed on the wrong window #7

merged 4 commits into from
Jan 22, 2025

Conversation

@EchoEllet
Copy link
Contributor

@EchoEllet EchoEllet commented Jan 21, 2025 •
edited
Loading

Fixing:

Currently, the ImagePickerImpl.swift coverage is low but tests are planned and will be added (#6) before working on new features (e.g., #5).

The Swift code will be refactored to be testable and we may refer to file_selector during the process.

PickerSheet.mov

@EchoEllet EchoEllet marked this pull request as ready for review January 21, 2025 22:19
@EchoEllet EchoEllet mentioned this pull request Jan 21, 2025
Closed
@EchoEllet EchoEllet merged commit f4f4d21 into main Jan 22, 2025
2 checks passed
@EchoEllet EchoEllet deleted the fix/display-picker branch January 22, 2025 08:38
This was linked to issues Jan 22, 2025
Sheet may be displayed on the wrong window (or not displayed) #4
Closed
The size of the native window picker is too small #2
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sheet may be displayed on the wrong window (or not displayed) The size of the native window picker is too small

2 participants

@EchoEllet