-
Notifications
You must be signed in to change notification settings - Fork 87
Feat/add stress #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/add stress #103
Conversation
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 71.85% 71.75% -0.10%
==========================================
Files 129 129
Lines 14022 14049 +27
==========================================
+ Hits 10075 10081 +6
- Misses 3947 3968 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hey Daniel, thanks for working on this, looking good so far! I have one question: maybe I am wrong but I don't think we can have another normalization for the pressure tensor because there is currently already a "normalized" energy and length unit. Since the pressure tensor will be of (energy/length^3) units this already fixes the numeric magnitude, right? I have not thought about this in detail... However, it is important to consider that many programs will output the pressure tensor in units like kBar or Pa, hence this should be converted before used as an input in the data file. Have you already done this in your example? Thanks a lot anyway for providing an example, this is very helpful! Best, Andi |
Hi Andi,
This is a very good point and I hadn't thought of it. If this is what happens for the forces then the stresses should follow the same pattern.
Thanks for thinking of this, yep, this has already been handled! (In my case the output was in GPa and I've converted everything to Hartree/Bohr^3 units). I actually have the stresses for 5000 structures and a reasonably well-trained NNP for them. A good early goal could be to test the analytic prediction of stresses (we should be able to get results that are at least reasonable for most structures). Daniel |
Some points for discussion: