Skip to content

Change IndexOf APIs to return -1 if not found #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2022
Merged

Change IndexOf APIs to return -1 if not found #190

merged 2 commits into from
Apr 4, 2022

Conversation

Sergio0694
Copy link
Member

Closes #189

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKsentire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added feature 💡 A new feature being implemented improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change next preview ✈️ This changes will be available in the upcoming preview high-performance 🚂 Issues/PRs for the HighPerformance package labels Mar 30, 2022
@Sergio0694 Sergio0694 requested a review from Arlodotexe March 31, 2022 12:01
@Sergio0694 Sergio0694 merged commit 0e2a94c into main Apr 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/fix-indexof-return branch April 4, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

+1 more reviewer

@powerdude powerdude powerdude left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature 💡 A new feature being implemented high-performance 🚂 Issues/PRs for the HighPerformance package improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change next preview ✈️ This changes will be available in the upcoming preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change IndexOf<T>([ReadOnly]Span<T>, ref/in T) to return -1 instead of throwing

3 participants

@Sergio0694 @powerdude @Arlodotexe