-
Notifications
You must be signed in to change notification settings - Fork 339
Move collection types to MVVM Toolkit #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76f36fb
to
bb33459
Compare
🎉🎉🎉🎉 |
bb33459
to
68eb1fd
Compare
Will this have things like AddRange, remove range, etc? Similar to https://github.com/jamesmontemagno/mvvm-helpers/blob/master/MvvmHelpers/ObservableRangeCollection.cs |
Hey @jamesmontemagno, that's actually something that I specifically don't want to add. We've talked about this with @michael-hawker and @brminnick (who also had the same question, as they currently have similar helpers in the MAUI Community Toolkit, which are being removed as they standardize towards the MVVM Toolkit), and my position was that we should instead try to help make dotnet/runtime#65101 happen, and then just use that. Currently the PR is in the works, we mostly just need to talk to the WinUI 3 team to see if they can support it too (not being open source we can't just contribute to it like with WPF), and confirm that MAUI will support that too (maybe you and Brandon can help clarify this?). With that, it'll be a much better end result for consumers, as the API having proper support both has much better performance, as well as offering better UI animations (the UI can only animate the replaces items instead of resetting the whole collection). As we said before, the goal here is to put together the best possible API set for consumers in the long term, and we feel like this is the right direction to achieve that 🙂 Hope this helps! |
Anything new or added here? This is just a namespace/package change, right? Curious why they're not all showing as moves. |
@michael-hawker Yes there's a bunch of changes I want to discuss in today's API review 🙂 |
Capturing notes from discussion today:
That'll make things easier to review. :) For the new PR:
|
68eb1fd
to
5451972
Compare
Ahhhh i gotcha now, yeah that makes sense looking at the docs what this is. Still great ;) |
YOLO-merging this one since it's just the move we discussed, so I can open the new PR with API changes 😄 |
Closes #138
This PR moves the collection types with no further changes, other than the namespace.
Follow up API changes will be done in a separate PR.