AttachedDropShadowCrashFix #4757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks LalithaNadimpalli for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested a review
from 
ghost
added
bug 🐛
Adding a null reference check to AttachedDropShadow crash issue
michael-hawker
force-pushed
the
PR4750Fix
branch
from
d34d637 to
3ca0e49
Compare
Arlodotexe
approved these changes
Sep 20, 2022
michael-hawker
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a null reference check to AttachedDropShadow crash issue
Fixes #4750
Fixes the sudden crash of sample app when we add Xaml code
PR Type
What kind of change does this PR introduce?
Bugfix
Sample app changes
What is the current behavior?
Sample app Crash when we add Xaml Code
What is the new behavior?
Fixes the Crash
PR Checklist
Please check if your PR fulfills the following requirements:
Based off latest main branch of toolkit
Tested code with current supported SDKs
Sample in sample app has been added / updated (for bug fixes / features)
Other information