Skip to content

Fix AttachedDropShadow size changes abnormally #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Fix AttachedDropShadow size changes abnormally #4549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7ba0fa
Fix AttachedDropShadow size changes abnormally
chenjt2001 May 6, 2022
59cd9fe
Avoid adding shapes repeatedly
chenjt2001 May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Microsoft.Toolkit.Uwp.UI/Shadows/AttachedDropShadow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,11 @@ protected override CompositionBrush GetShadowMask(AttachedShadowElementContext c
// Create a ShapeVisual so that our geometry can be rendered to a visual
var shapeVisual = context.GetResource(ShapeVisualResourceKey) ??
context.AddResource(ShapeVisualResourceKey, context.Compositor.CreateShapeVisual());
shapeVisual.Shapes.Add(shape);

if (!shapeVisual.Shapes.Contains(shape))
{
shapeVisual.Shapes.Add(shape);
}

// Create a CompositionVisualSurface, which renders our ShapeVisual to a texture
var visualSurface = context.GetResource(VisualSurfaceResourceKey) ??
Expand Down Expand Up @@ -344,6 +348,7 @@ protected internal override void OnSizeChanged(AttachedShadowElementContext cont
context.SpriteVisual.Offset = context.Element.CoordinatesFrom(CastTo).ToVector3();

UpdateShadowClip(context);
UpdateShadowMask(context);

base.OnSizeChanged(context, newSize, previousSize);
}
Expand Down