Skip to content

Conversation

@Nirmal4G
Copy link
Contributor

@Nirmal4G Nirmal4G commented Jan 11, 2022

Contributes to #4068

  • Use an emoji for Contributors' title
    Rest of the titles have emojis, why not this? So, I used Champion Cup (🏆) emoji.
  • Don't use inline HTML in markdown
    The format to represent image with a link is supported by most markdown parsers: [![alt-text](image-link)](info-link).

PR Type

What kind of change does this PR introduce?

  • ReadMe content changes (refactor and fixes)

What is the current behavior?

My markdown linter reports issues with in-line HTML.

What is the new behavior?

Made sure that we convert the in-line HTML to markdown format.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Contains NO breaking changes

Other information

Squash merge if possible.

@ghost
Copy link

ghost commented Jan 11, 2022

Thanks Nirmal4G for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and michael-hawker January 11, 2022 11:40
Aligns with the rest of the titles
Always use markdown format if possible.
This format to represent image with a link is supported by most markdown parsers.
@zateutsch zateutsch merged commit 1e7776e into CommunityToolkit:main Jan 18, 2022
@Nirmal4G Nirmal4G deleted the hotfix/readme branch January 19, 2022 01:17
@michael-hawker michael-hawker added this to the 7.1.3 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants