Fix Radial Gauge ScaleTickBrush color assignment #4362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a typo or a merge conflict, the ScaleTickBrush of the RadialGauge control currently gets the color of the ScaleBrush instead of its own.
|
Thanks XamlBrewer for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
michael-hawker
approved these changes
Nov 2, 2021
michael-hawker
added
bug 🐛
XAML-Knight
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a typo or a merge conflict, the ScaleTickBrush of the RadialGauge control currently gets the color of the ScaleBrush instead of its own.
Fixes
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The ScaleTickBrush property accidently gets its value from the ScaleBrush value in XAML or Resource Dictionary.
What is the new behavior?
The ScaleTickBrush gets its value from the corresponding XAML setting or Resource Dictionary.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information