Updated Windows SDK locator script to make it more resilient to x86 vs x64 environments. #4146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s x64 environments.
michael-hawker
approved these changes
Jul 29, 2021
|
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 57 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the Windows SDK locator script to make it check for both x64 and x86 registry keys. The ADO build server, as well as some of our machines, are reproducing this odd behavior, and this PR addresses that bug.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
SDK locator script crashing depending if the registry keys that it looks for exists in x64 or x86 land.
What is the new behavior?
SDK locator script checks for both x64 and x86 registry keys, making it more reliable.
PR Checklist
Please check if your PR fulfills the following requirements: