Skip to content

Conversation

@puppetsw
Copy link
Contributor

Fixes #3279

Applies the fix suggest by oenarap in issue #3279 .

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

TextBoxMask leaves an artifact (i.e., old Text value) when a new value is set. (Through binding)

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

First attempt at a PR and fix. I hope I'm doing this right.

@ghost
Copy link

ghost commented May 27, 2021

Thanks puppetsw for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from Kyaa-dost, azchohfi and michael-hawker May 27, 2021 01:22
@net-foundation-cla
Copy link

net-foundation-cla bot commented May 27, 2021

CLA assistant check
All CLA requirements met.

@ghost ghost requested a review from Rosuavio May 27, 2021 01:22
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior extensions ⚡ labels May 27, 2021
Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, the text is masked, new text with different casing should be considered different than the old text.

But if we need to ignore casing, then it should be an option that a developer can set.

Let me test this and get back to you.

…Mask.Internals.cs


This makes sense. We shouldn't ignore the casing.

Co-authored-by: Nirmal Guru <Nirmal4G@gmail.com>
@ghost
Copy link

ghost commented May 28, 2021

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🚀

@michael-hawker michael-hawker changed the title Bug fix 3279 suggested by oenarap TextBoxMask TextChanging fix for #3279 Jun 24, 2021
@michael-hawker
Copy link
Member

@puppetsw would you be up for adding a new unit test for guarding regressions as well? We have info in our wiki now about this here. There's also an existing UI Test for checking binding you could copy as well, but think it may be simpler to have a unit test for this too since you could update the binding text via code in the test as well with the VisualUITestBase.

@ghost ghost removed the needs attention 👋 label Jun 29, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Jun 29, 2021
@puppetsw
Copy link
Contributor Author

puppetsw commented Jun 29, 2021

@michael-hawker Sure can do. I'll write up something shortly.

Edit: I'm not sure if this was the best way to handle this I couldn't figure out a way to test this with VisualUITestBase. So I piggy-backed onto the existing TextBoxMask UI test.

@michael-hawker michael-hawker merged commit ee5a7b8 into CommunityToolkit:main Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior extensions ⚡

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextBoxMask TextChanging event handler bug

5 participants