Enabled correct WeakReferenceMessenger path on .NET 5

[Sergio0694]

Follow up for #3424

PR Type

What kind of change does this PR introduce?

• Bugfix-ish

Overview

The .NET 5 target currently uses the .NET Standard 2.0 code path within WeakReferenceMessenger.
Not technically a bug since the implementation does work, but it can be greatly simplified like on .NET Standard 2.1.
This should also make the code add slightly less GC pressure over time due to less additional data structures in use.

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository instructions. Link:
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

[ghost]

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[Sergio0694]

Hey @azchohfi - just FYI in case you haven't noticed it, I think the CI is currently broken for this repo 🤔
Both this and other PRs (eg. #3929 and #3906) are failing with the same CI error, though they build fine locally:

Unhandled Exception: System.InvalidOperationException: Sequence contains more than one element
   at System.Linq.Enumerable.Single[TSource](IEnumerable`1 source)
   at InheritDocLib.XElementX.CopyFrom(XElement target, XElement source, String[] pathParts)
   at InheritDocLib.InheritDocUtil.MergeMemberElements(ICollection`1 assemblyDocuments, ICollection`1 allAssemblyDocuments, IDictionary`2 typeDocByName, String typeName, TypeDoc typeDoc, String cref, MemberElementName memberElementName, String path, Action`2 logger)
   at InheritDocLib.InheritDocUtil.ReplaceInheritDocs(ICollection`1 assemblyDocuments, ICollection`1 allAssemblyDocuments, IDictionary`2 typeDocByName, ICollection`1 sortedTypeNames, Action`2 logger)
   at InheritDocLib.InheritDocUtil.Run(String basePath, String xmlDocFileNamePatterns, String globalSourceXmlFiles, String excludeTypes, Boolean overwriteExisting, Action`2 logger)
   at InheritDoc.Program.<>c.<Main>b__1_1(Options options)
   at CommandLine.ParserResultExtensions.WithParsed[T](ParserResult`1 result, Action`1 action)
   at InheritDoc.Program.Main(String[] args)
An error occurred when executing task 'InheritDoc'.

Not sure it's related to some doc issue in the repo since the main branch is building just fine from what I can see.
Any ideas? 😄

EDIT: I'm terribly sorry to the other Alex for the accidental ping, I clicked on the wrong autocomplete item 😅

[azchohfi]

cherry pick this:
fd9ce62

[Sergio0694]

Worked like a charm, thanks @azchohfi! You're the ultimate git/CI wizard 🙌🧙‍♂️✨

[ghost]

Hello @RosarioPulella!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[michael-hawker]

FYI @shweaver-MSFT, you were also hitting the InheritDoc issue.