Windows 10X and Two-pane view support #3768

COM8 · 2021-02-19T07:24:30Z

Fixes #3173

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

The ListDetailsView does not take advantage of multiple screens on Windows 10X devices.

What is the new behavior?

The new and refactored ListDetailsView control is aware of multiple screens when used on Windows 10X devices.
We archive this by replacing the current grid-based layout with the new Two-pane view based layout.

Additional changes

I added additional properties: DetailsPaneBackground, DetailsContentTemplateSelector, ListPaneNoItemsContent, ListPaneNoItemsContentTemplate and ListPaneItemTemplateSelector.
~~I added a new NuGet dependency: Microsoft.UI.Xaml to Microsoft.Toolkit.Uwp.UI.Controls.Layout, so I would be able to use the TwoPaneView class regardlessof the current Windows 10 version.~~
~~Renamed the ListCommandBar property to ListPaneCommandBar. For more consitency with property names.~~
~~Renamed the DetailsCommandBar property to DetailsPaneCommandBar. For more consitency with property names.~~

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs
Pull Request has been submitted to the documentation repository instructions. Link: #559
Sample in sample app has been added / updated (for bug fixes / features)
- Icon has been created (if new sample) following the Thumbnail Style Guide and templates
New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
Tests for the changes have been added (for bug fixes / features) (if applicable)
Header has been added to all new source files (run build/UpdateHeaders.bat)
Contains NO breaking changes

Other information

Old behavior

New behavior

ghost · 2021-02-19T07:24:33Z

Thanks COM8 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

COM8 · 2021-02-19T07:28:13Z

What should I do about the documentation over at MicrosoftDocs/WindowsCommunityToolkitDocs#304?
Should I create a new file called ListDetailsView in the appropriate path since I noticed it still uses the MasterDetailsView documentation.

michael-hawker · 2021-02-19T18:32:56Z

@COM8 yeah, we haven't updated the documentation with the rename yet. We'll be doing that in the next couple of weeks as we prep for release. I can let you know when that happens and we can rebase that PR of yours after?

COM8 · 2021-02-20T09:31:49Z

@COM8 yeah, we haven't updated the documentation with the rename yet. We'll be doing that in the next couple of weeks as we prep for release. I can let you know when that happens and we can rebase that PR of yours after?

Sounds great.

michael-hawker · 2021-03-11T21:12:34Z

@COM8 looks like there's a build issue?

D:\a\1\s\UnitTests\UnitTests.UWP\UI\Controls\Test_ListDetailsView.cs(22,49): error CS1061: 'ListDetailsView' does not contain a definition for 'SelectedIndex' and no accessible extension method 'SelectedIndex' accepting a first argument of type 'ListDetailsView' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\UI\Controls\Test_ListDetailsView.cs(42,29): error CS1061: 'ListDetailsView' does not contain a definition for 'SelectedIndex' and no accessible extension method 'SelectedIndex' accepting a first argument of type 'ListDetailsView' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\UI\Controls\Test_ListDetailsView.cs(53,29): error CS1061: 'ListDetailsView' does not contain a definition for 'SelectedIndex' and no accessible extension method 'SelectedIndex' accepting a first argument of type 'ListDetailsView' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\UI\Controls\Test_ListDetailsView.cs(54,29): error CS1061: 'ListDetailsView' does not contain a definition for 'SelectedIndex' and no accessible extension method 'SelectedIndex' accepting a first argument of type 'ListDetailsView' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\UI\Controls\Test_ListDetailsView.cs(67,49): error CS1061: 'ListDetailsView' does not contain a definition for 'SelectedIndex' and no accessible extension method 'SelectedIndex' accepting a first argument of type 'ListDetailsView' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\UI\Controls\Test_ListDetailsView.cs(78,48): error CS1061: 'ListDetailsView' does not contain a definition for 'SelectedIndex' and no accessible extension method 'SelectedIndex' accepting a first argument of type 'ListDetailsView' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]

COM8 · 2021-03-12T12:58:34Z

Fixed. Sorry forgot to check the CI run since it took soo long the first time :D

skendrot

I'm glad this got in here. I had a hard time reviewing the code due to methods getting moved around what appears to be randomly.
I'm concerned that this is slated for 7.1. It contains a lot of breaking changes

Microsoft.Toolkit.Uwp.UI.Controls.Layout/ListDetailsView/ListDetailsView.Properties.cs

skendrot · 2021-03-12T21:16:47Z

Microsoft.Toolkit.Uwp.UI.Controls.Layout/ListDetailsView/ListDetailsView.cs

        /// </summary>
-        protected override void OnApplyTemplate()
+        /// <param name="animate">False to skip animations.</param>
+        private void SetVisualState(bool animate)


Methods have been moved around making review very hard. private methods should be below public/protected methods

Fixed the method order.

Microsoft.Toolkit.Uwp.UI.Controls.Layout/ListDetailsView/ListDetailsView.xaml

Microsoft.Toolkit.Uwp.UI.Controls.Layout/ListDetailsView/ListDetailsView.Properties.cs

ghost · 2021-03-16T16:47:41Z

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

COM8 · 2021-03-16T16:56:27Z

Sorry for the moved arround methods.
That's because for this PR I rebuild the control from the beginning up again and extended it to fit my need in my app.
In case it's really required I can reorder all methods again, but this would take some time.

michael-hawker · 2021-06-17T20:46:58Z

@COM8 if you'd like to get this in sooner, think we can do things without changing property names or types? Or is that pretty pivotal to the other updates you've made?

We're not too sure when our next major version is going to be. Otherwise, we may have another spot in the next month or so we could put this to get some more folks to test out the changes until such time we can swap them out.

COM8 · 2021-06-26T17:42:30Z

Sure, I can change the name of for example ListPaneCommandBar back to ListCommandBar, but this is then not consistent to the other teminology used in the docs. There you are always talking abot list pane and details pane.

michael-hawker · 2021-08-10T16:53:56Z

@COM8 yeah, if we want to move forward with the PR though, we wouldn't want to make breaking changes for our upcoming minor release. I think it's something we can still clarify with the documentation comments on the properties.

Did you want to keep them the same so we can move forward? Couple of conflicts to resolve as well?

COM8 · 2021-08-12T07:38:30Z

Ok, I will work on it in the next to weeks so we can move on :)

COM8 · 2021-08-15T14:33:45Z

@michael-hawker Done.
Just need to update the docs.
How do I add properties there? Do I edit the docs manually or can I generate the framework somehow for the new properties?

XAML-Knight · 2021-08-17T22:46:02Z

Just need to update the docs.
How do I add properties there? Do I edit the docs manually or can I generate the framework somehow for the new properties?

Hi @COM8, for guidance on updating the Docs, take a look here, here, and here.

Currently, this is a manual process

COM8 · 2021-08-23T08:28:05Z

Just need to update the docs.
How do I add properties there? Do I edit the docs manually or can I generate the framework somehow for the new properties?

Hi @COM8, for guidance on updating the Docs, take a look here, here, and here.
* Currently, this is a manual process

Thanks. Done: MicrosoftDocs/WindowsCommunityToolkitDocs#559

michael-hawker · 2021-08-24T16:02:11Z

Thanks @COM8 as long as we're back to no breaking changes, we can remove that label and get this in for 7.1 this week I hope.

XAML-Knight · 2021-08-24T17:21:16Z

Hi @COM8 , it appears you're trying to merge this code in from the master branch of your forked repo.

Please be aware of the rules & stipulations of submitting code into the Toolkit repo:

COM8 · 2021-08-24T17:33:52Z

@michael-hawker should I create a new PR from my feature/two-pane-view branch, so the @XAML-Knight is happy?

michael-hawker · 2021-08-25T20:37:29Z

Microsoft.Toolkit.Uwp.UI.Controls.Layout/ListDetailsView/ListDetailsView.Properties.cs

@@ -162,7 +212,7 @@ public partial class ListDetailsView
            nameof(CompactModeThresholdWidth),
            typeof(double),
            typeof(ListDetailsView),
-            new PropertyMetadata(720d, OnCompactModeThresholdWidthChanged));
+            new PropertyMetadata(640d));


Why did we change the default value here?

I changed this value, so we have a better two too one ratio between the CompactModeThresholdWidth and the ListPaneWidth.

michael-hawker · 2021-08-26T20:25:51Z

@michael-hawker should I create a new PR from my feature/two-pane-view branch, so the @XAML-Knight is happy?

Yes, can you submit a new PR from your feature/two-pane-view branch, doesn't look like we can edit the branch this PR is coming from. Thanks!

michael-hawker · 2021-08-26T20:26:21Z

Going to close this one, as we'll wait to do final review on the new PR opened.

COM8 · 2021-08-27T14:05:10Z

#4197

ghost requested review from michael-hawker, azchohfi, Kyaa-dost and Rosuavio February 19, 2021 07:24

ghost added the introduce breaking changes 💥 label Feb 19, 2021

michael-hawker added this to the 7.1 milestone Feb 19, 2021

michael-hawker added WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3. controls 🎛️ labels Feb 19, 2021

Kyaa-dost added the doc-InDraft ⏳ label Mar 3, 2021

skendrot suggested changes Mar 12, 2021

View reviewed changes

ghost added needs author feedback 📝 needs attention 👋 and removed needs author feedback 📝 labels Mar 12, 2021

michael-hawker mentioned this pull request May 25, 2021

[Future] 7.1 Release Plan #4045

Closed

27 tasks

ghost removed the needs attention 👋 label Jun 17, 2021

COM8 added 2 commits August 15, 2021 14:12

Windows 10X TwoPaneView for ListDetailsView

a5fc9eb

Fixed ambiguous doc hint

e3f5a7f

michael-hawker added the sdkcheck 🏁 label Aug 17, 2021

COM8 mentioned this pull request Aug 23, 2021

ListDetailsView Two-pane view documentation update MicrosoftDocs/WindowsCommunityToolkitDocs#559

Merged

5 tasks

michael-hawker added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Aug 24, 2021

michael-hawker added for-review 📖 To evaluate and validate the Issues or PR and removed sdkcheck 🏁 labels Aug 24, 2021

michael-hawker reviewed Aug 25, 2021

View reviewed changes

michael-hawker closed this Aug 26, 2021

michael-hawker mentioned this pull request Aug 25, 2022

ListDetailsView not working with WinUI3/WindowsAppSDK 1.0.0-preview3 #4357

Closed

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows 10X and Two-pane view support #3768

Windows 10X and Two-pane view support #3768

COM8 commented Feb 19, 2021 •

edited

Loading

ghost commented Feb 19, 2021

COM8 commented Feb 19, 2021

michael-hawker commented Feb 19, 2021

COM8 commented Feb 20, 2021

michael-hawker commented Mar 11, 2021

COM8 commented Mar 12, 2021

skendrot left a comment

skendrot Mar 12, 2021

COM8 Mar 16, 2021

ghost commented Mar 16, 2021

COM8 commented Mar 16, 2021

michael-hawker commented Jun 17, 2021

COM8 commented Jun 26, 2021

michael-hawker commented Aug 10, 2021

COM8 commented Aug 12, 2021

COM8 commented Aug 15, 2021

XAML-Knight commented Aug 17, 2021

COM8 commented Aug 23, 2021

michael-hawker commented Aug 24, 2021

XAML-Knight commented Aug 24, 2021

COM8 commented Aug 24, 2021

michael-hawker Aug 25, 2021

COM8 Aug 26, 2021

michael-hawker commented Aug 26, 2021

michael-hawker commented Aug 26, 2021

COM8 commented Aug 27, 2021

Windows 10X and Two-pane view support #3768

Windows 10X and Two-pane view support #3768

Conversation

COM8 commented Feb 19, 2021 • edited Loading

Fixes #3173

PR Type

What is the current behavior?

What is the new behavior?

Additional changes

PR Checklist

Other information

Old behavior

New behavior

ghost commented Feb 19, 2021

COM8 commented Feb 19, 2021

michael-hawker commented Feb 19, 2021

COM8 commented Feb 20, 2021

michael-hawker commented Mar 11, 2021

COM8 commented Mar 12, 2021

skendrot left a comment

Choose a reason for hiding this comment

skendrot Mar 12, 2021

Choose a reason for hiding this comment

COM8 Mar 16, 2021

Choose a reason for hiding this comment

ghost commented Mar 16, 2021

COM8 commented Mar 16, 2021

michael-hawker commented Jun 17, 2021

COM8 commented Jun 26, 2021

michael-hawker commented Aug 10, 2021

COM8 commented Aug 12, 2021

COM8 commented Aug 15, 2021

XAML-Knight commented Aug 17, 2021

COM8 commented Aug 23, 2021

michael-hawker commented Aug 24, 2021

XAML-Knight commented Aug 24, 2021

COM8 commented Aug 24, 2021

michael-hawker Aug 25, 2021

Choose a reason for hiding this comment

COM8 Aug 26, 2021

Choose a reason for hiding this comment

michael-hawker commented Aug 26, 2021

michael-hawker commented Aug 26, 2021

COM8 commented Aug 27, 2021

COM8 commented Feb 19, 2021 •

edited

Loading