Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetadataControl #3686

Merged
8 commits merged into from
Jun 16, 2021
Merged

Add MetadataControl #3686

8 commits merged into from
Jun 16, 2021

Conversation

vgromfeld
Copy link
Contributor

@vgromfeld vgromfeld commented Jan 22, 2021

Fixes #3688

Adds a control to display metadata separated by bullets like done in Groove Music or the Store.
The metadata list can contain actionable links.

Groove
groove

Store
store

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

I've added MetadataControl. It aggregates strings and commands separated by bullets ("•" / U+2022) in a TextBlock.
The commands are represented using Hyperlink items.
It receives the items to display as MetadataUnits through its MetadataControl.MetadataUnits property.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

image

@ghost
Copy link

ghost commented Jan 22, 2021

Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@michael-hawker
Copy link
Member

Thanks @vgromfeld, this seems like an interesting control/use-case. Mind opening up a tracking issue as well for discussion on API usage? Going to mark as draft for now as well.

@michael-hawker michael-hawker marked this pull request as draft January 22, 2021 19:33
@vgromfeld vgromfeld marked this pull request as ready for review January 25, 2021 10:32
@michael-hawker michael-hawker added this to the 7.1 milestone Feb 4, 2021
@michael-hawker michael-hawker marked this pull request as draft February 4, 2021 21:43
@michael-hawker michael-hawker mentioned this pull request May 25, 2021
27 tasks
@vgromfeld vgromfeld marked this pull request as ready for review June 9, 2021 21:29
@michael-hawker
Copy link
Member

@Kyaa-dost @RosarioPulella want to take this for a spin and add any thoughts or sign-off?

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 🚀

@ghost
Copy link

ghost commented Jun 16, 2021

Hello @RosarioPulella!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ff21a8a into CommunityToolkit:main Jun 16, 2021
@vgromfeld vgromfeld deleted the metadataControl branch June 16, 2021 13:57
@mdtauk
Copy link

mdtauk commented Jun 16, 2021

Hopefully the separating glyph is changeable

@michael-hawker
Copy link
Member

Thanks @mdtauk for taking a look, yup there's a Separator property which configures that:

https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/3686/files#diff-4963bd8033cbffcab9fad275c6afd9a956654daf27125ba4228c650dc09f1c20R25-R29

@michael-hawker
Copy link
Member

@vgromfeld when you have a chance can you open a docs PR for this? There's a template here Thanks!

@vgromfeld
Copy link
Contributor Author

@michael-hawker done: MicrosoftDocs/WindowsCommunityToolkitDocs#537 :).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add a control to display a list of metadata
6 participants