Skip to content

Conversation

@Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Nov 3, 2020

Reopen #3512

Add UI tests for TextBox with a TextBoxMask.Mask and x:Bind
Uses WinUI Test Infrasttcure from #3482 to test the fix from #3338 for #3335.

PR Type

What kind of change does this PR introduce?

  • Feature
  • Build or CI related changes

What is the current behavior?

No UI Tests for TextBoxMask

What is the new behavior?

Given a TextBox with a Mask set and its Text bound to a C# property using x:Bind. It tests if the text in the TextBox updates when that property is updated.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • [ ] Pull Request has been submitted to the documentation repository instructions. Link:
  • ~~[ ] Sample in sample app has been added / updated (for bug fixes / features) ~~
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Does not test #3514

@ghost
Copy link

ghost commented Nov 3, 2020

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from Kyaa-dost, azchohfi and michael-hawker November 3, 2020 00:26
@Rosuavio Rosuavio changed the title Test text box mask Test TextBox with a TextBoxMask.Mask and x:Bind Nov 3, 2020
This was referenced Nov 24, 2020
@Rosuavio Rosuavio closed this Dec 4, 2020
@Rosuavio
Copy link
Contributor Author

Rosuavio commented Dec 4, 2020

Closing in favor of #3580

ghost pushed a commit that referenced this pull request Dec 11, 2020
Quick prototype to test out an app service on top of #3552.

Working locally with MSTest, though some oddities when trying to shore-up timing guards, unknown unhandled exception... Went back to looser code and working well. Not sure if this resolves the TAEF error we're seeing in #3552 yet, but wanted to see if this provided different info.

Lots to do here to clean this work up, as I just hacked things together to see if it would work, but looking very promising. This should allow us to optimize the start-up performance of the app more easily as well as have a bi-directional communication pipe between our two processes for logging messages from the host within the harness/CI logs. 🎉

FYI @RosarioPulella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants