Add new 'DesignTools' projects #3318

Nirmal4G · 2020-05-31T20:34:17Z

Fixes #3252

Created the DesignTools projects and refactored the code to work with the new XAML Designer.

~~Both Design and DesignTools projects live SxS (Side by Side) now, so that, we can ship for both the designers for the foreseeable future.~~
Reason: It was decided that we don't need to support older Designer anymore.

Part of #3062

More info in each of the commits' description.

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Refactoring (no functional changes)
Build

What is the current behavior?

Design tools don't work well with our controls (after VS v16.4 upgrade) because of the new XAML designer.

What is the new behavior?

Now the design tools should work as before as the new DesignTools projects have been introduced to work with the new XAML designer.

PR Checklist

Please check if your PR fulfils the following requirements:

Tested code with current supported SDKs
Header has been added to all new source files (run build/UpdateHeaders.bat)
Contains NO breaking changes

Other information

Conversion to Sdk-style, adding more metadata and using source generators (once enough docs/samples available) to do it, will come in later PRs.

ghost · 2020-05-31T20:34:21Z

Thanks Nirmal4G for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Microsoft.Toolkit.Uwp.UI.Controls.Design/Common/Constants.cs

Microsoft.Toolkit.Uwp.UI.Controls.DataGrid.Design/MetadataRegistration.cs

...wp.UI.Controls.DataGrid.Design/Microsoft.Toolkit.Uwp.UI.Controls.DataGrid.DesignTools.csproj

azchohfi · 2020-06-24T22:53:26Z

@Nirmal4G any update on this?

michael-hawker · 2020-09-01T17:47:24Z

@Nirmal4G see you have some commits here, are you expecting more changes or should we try to test this out in its current state?

Nirmal4G · 2020-09-01T19:55:27Z

@michael-hawker I still have that problem where I need an alternative solution to using the XML Doc.

Tried a few things, I might have something working as a potential replacement. Will update here once it's ready for review.

Nirmal4G · 2020-09-01T19:59:27Z

Feel free to test it out. From this point it's just fixes and metadata additions for more controls.

Microsoft.Toolkit.Uwp.UI.Controls.Design/MetadataRegistration.cs

michael-hawker · 2020-12-01T19:04:00Z

Thanks @Nirmal4G! 🎉 Looks like the build section of the CI has completed, just waiting on tests and smoke tests, then we should be able to test out the new NuGet packages directly.

Is everything else ready to go now? We can get a few folks to check out the changes and play with the designer.

I'd like @azchohfi to review the build property changes too.

Nirmal4G · 2020-12-01T19:18:33Z

Is everything else ready to go now?

Yes.

we need to start our next refactor

I've skipped CodeGen changes for now because of this. I'll open a PR on top of the refactoring changes. Is there an issue or a PR open currently to know what should I expect?

michael-hawker · 2020-12-01T19:19:41Z

@Nirmal4G smoke tests have an issue which is what I was afraid of with your changes to the props/target files:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\WindowsXaml\v16.0\Microsoft.Windows.UI.Xaml.Common.targets(6,18): error MSB4086: A numeric comparison was attempted on "$(TargetPlatformMinVersion)" that evaluates to "10.0..0" instead of a number, in condition "'$(TargetPlatformIdentifier)' == 'UAP' And '$(TargetPlatformMinVersion)' != '' And '$(TargetPlatformMinVersion)' > '10.0.10587.0'". [D:\a\1\s\SmokeTests\SmokeTest.csproj]

Did you modify those for any specific purpose for the DesignTools projects? Just trying to understand the updates. I'm pretty sure there's a reason we have the break-out between the DefaultTargetPlatformVersion and TargetPlatformVersion, but I'm not sure if it's just a matter of updating the SmokeTest project to use your updates or something else. @azchohfi knows more about this than I do, but he's not available this week.

Nirmal4G · 2020-12-01T19:27:13Z

Yeah... I'm looking into it. Some changes between now and then broke it when I rebased on top of the latest master.

Found the issue: PR #3450 created smoke tests and the project file used older DefaultTargetPlatformVersion which I replaced with TargetPlatformRevision and same for min version property too. Since it was added later, I didn't see it in my rebase.

I renamed the property names and that should let the tests build properly now.

michael-hawker · 2020-12-01T21:22:54Z

Thanks so much @Nirmal4G for being on top of updates this morning! 🎉🎉🎉

We'll take a look at vetting the NuGets which have generated now and see how things are working. It'll be great to finally get this all together. Thanks so much again for your patience in getting this together for us, it's been very much appreciated. 🦙❤

@RosarioPulella want to do an initial pass next of updating to these PR NuGets in a fresh VS project and seeing how things work in the Designer with VS 2019 16.8.2?

Rosuavio

Works well in my testing @michael-hawker.

michael-hawker

Looking good! Not sure why @Nirmal4G, but I couldn't see the MarkdownTextBlock in the Toolbox. I can't see an obvious reason why something would be different here? Main package and DataGrid seemed to work fine.

Can you also add a Wiki Page for this under the Development/Testing section with some guidance on how this project is setup and how someone would go about modifying info here or adding data for a new control? For instance are the Typedata files just hand-crafted copies?

@azchohfi can you take a quick glance at the prop/target file changes? Otherwise, I'm good with this once we tweak the MarkdownTextBlock package.

Directory.Build.props

Microsoft.Toolkit.Uwp.UI.Controls.Design/Common/Constants.cs

Microsoft.Toolkit.Uwp.UI.Controls.Design/Controls/TextToolbar.Typedata.cs

Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj

build/Windows.Toolkit.VisualStudio.Design.props

Going to fix-forward after and get this merged.

ghost · 2020-12-10T21:18:40Z

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

michael-hawker · 2020-12-10T21:27:51Z

This should merge after the build, created #3620 to follow-up on remaining small open issues.

ghost · 2021-02-28T16:55:22Z

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

ghost assigned azchohfi May 31, 2020

ghost added feature request 📬 A request for new changes to improve functionality improvements ✨ labels May 31, 2020

Nirmal4G commented May 31, 2020

View reviewed changes

Microsoft.Toolkit.Uwp.UI.Controls.Design/Common/Constants.cs Outdated Show resolved Hide resolved

Microsoft.Toolkit.Uwp.UI.Controls.DataGrid.Design/MetadataRegistration.cs Outdated Show resolved Hide resolved

michael-hawker requested review from azchohfi and dotMorten June 1, 2020 18:11

vgromfeld reviewed Jun 4, 2020

View reviewed changes

...wp.UI.Controls.DataGrid.Design/Microsoft.Toolkit.Uwp.UI.Controls.DataGrid.DesignTools.csproj Show resolved Hide resolved

Nirmal4G force-pushed the feature/design-tools branch from ca37481 to 66e841a Compare June 9, 2020 21:37

michael-hawker mentioned this pull request Jun 23, 2020

[Future] 7.0 Release Plan #3062

Closed

70 tasks

Nirmal4G force-pushed the feature/design-tools branch from 66e841a to 5762d01 Compare July 10, 2020 07:52

Nirmal4G force-pushed the feature/design-tools branch from 5762d01 to d11909b Compare July 17, 2020 17:21

michael-hawker added this to the 7.0 milestone Aug 18, 2020

This was referenced Aug 18, 2020

Update Contribution Guide #3269

Merged

Split Markdown.* from Controls package. #3437

Merged

Nirmal4G force-pushed the feature/design-tools branch from d11909b to 6c1bac0 Compare September 1, 2020 15:40

michael-hawker added the reviewers wanted ✋ label Sep 8, 2020

marcelwgn reviewed Sep 11, 2020

View reviewed changes

Microsoft.Toolkit.Uwp.UI.Controls.Design/MetadataRegistration.cs Outdated Show resolved Hide resolved

Nirmal4G force-pushed the feature/design-tools branch from 6c1bac0 to 757bc97 Compare September 14, 2020 21:28

Nirmal4G force-pushed the feature/design-tools branch 3 times, most recently from 8fb133b to 263eab3 Compare September 24, 2020 23:51

Nirmal4G force-pushed the feature/design-tools branch 2 times, most recently from 42bc139 to c6e61cd Compare October 9, 2020 10:15

Nirmal4G marked this pull request as ready for review October 9, 2020 10:17

Nirmal4G requested a review from michael-hawker October 9, 2020 10:17

Nirmal4G force-pushed the feature/design-tools branch from 91d81fa to 078bc12 Compare December 1, 2020 18:22

Nirmal4G force-pushed the feature/design-tools branch from 078bc12 to 9019a28 Compare December 1, 2020 19:46

Rosuavio approved these changes Dec 2, 2020

View reviewed changes

Merge branch 'master' into feature/design-tools

1cace8c

michael-hawker approved these changes Dec 8, 2020

View reviewed changes

Merge branch 'master' into feature/design-tools

ea949d6

michael-hawker added auto merge ⚡ and removed auto merge ⚡ labels Dec 8, 2020

CommunityToolkit deleted a comment Dec 8, 2020

azchohfi previously requested changes Dec 8, 2020

View reviewed changes

ghost added the needs author feedback 📝 label Dec 8, 2020

michael-hawker mentioned this pull request Dec 9, 2020

Test app service in CI #3580

Merged

Merge branch 'master' into feature/design-tools

2e2c27b

michael-hawker added the auto merge ⚡ label Dec 10, 2020

michael-hawker mentioned this pull request Dec 10, 2020

[Follow-up] Remaining Items TODO for DesignTools Refactor #3620

Closed

7 tasks

ghost merged commit 0975081 into CommunityToolkit:master Dec 10, 2020

ghost added needs attention 👋 and removed needs author feedback 📝 labels Feb 28, 2021

Nirmal4G mentioned this pull request Feb 28, 2021

Convert DesignTools projects to Sdk-style #3794

Merged

4 tasks

michael-hawker removed the needs attention 👋 label Mar 1, 2021

Nirmal4G mentioned this pull request Mar 4, 2021

Modernize DesignTools projects #3805

Closed

This pull request was closed.

Add new 'DesignTools' projects #3318

Add new 'DesignTools' projects #3318

Uh oh!

Conversation

Nirmal4G commented May 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes #3252

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

Uh oh!

ghost commented May 31, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azchohfi commented Jun 24, 2020

Uh oh!

michael-hawker commented Sep 1, 2020

Uh oh!

Nirmal4G commented Sep 1, 2020

Uh oh!

Nirmal4G commented Sep 1, 2020

Uh oh!

Uh oh!

michael-hawker commented Dec 1, 2020

Uh oh!

Nirmal4G commented Dec 1, 2020

Uh oh!

michael-hawker commented Dec 1, 2020

Uh oh!

Nirmal4G commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-hawker commented Dec 1, 2020

Uh oh!

Rosuavio left a comment

Choose a reason for hiding this comment

Uh oh!

michael-hawker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Dec 10, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

michael-hawker commented Dec 10, 2020

Uh oh!

ghost commented Feb 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Nirmal4G commented May 31, 2020 •

edited

Loading

Nirmal4G commented Dec 1, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.