Skip to content

Conversation

@azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Mar 15, 2020

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

Tests are only executed manually.

What is the new behavior?

Tests are executed after the build process.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 15, 2020

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned michael-hawker Mar 15, 2020
@azchohfi azchohfi force-pushed the testsCI branch 5 times, most recently from 6afd3b2 to 93c902c Compare March 15, 2020 06:17
@michael-hawker
Copy link
Member

Thanks Alex, this is great, we just need to fix the tests, tracking issue for that is #2133.

@michael-hawker
Copy link
Member

Closing as continued in #3207 as per @azchohfi

@Kyaa-dost Kyaa-dost deleted the testsCI branch August 26, 2020 21:32
@Kyaa-dost Kyaa-dost restored the testsCI branch August 26, 2020 21:32
@Kyaa-dost Kyaa-dost deleted the testsCI branch September 15, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants