Markdown + RSS Parser for .NET Standard, MarkdownTextBlock Style Improvements, Syntax Highlighting #1650

WilliamABradley · 2017-11-26T05:35:29Z

Moved Markdown Parser (along with RSS Parser) to new project Microsoft.Toolkit.Parsers.
Made required Parsing Classes and Enums public (I know I could have done InternalsVisibleTo, but then the Parser wouldn't be extensible.
Split the Markdown Parser from MarkdownTextBlock.
Create ~~IMarkdownRenderer~~ MarkdownRendererBase, make XamlRenderer inherit it.
Replace JavaScript based Syntax Highlighter in Sample App with ColorCode-Universal.
Add CodeBlock addornments and DocFX formatting in Sample App.
Add Parsing of Html <a> tags into new LinkAnchorInline.
Fix rendering of Code Blocks nested in Lists.

I also did some Restyling of the default Markdown to be further in line with Reddit and GitHub.

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting)
[x] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[x] Documentation content changes
[x] Sample app changes
[ ] Other... Please describe:

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs
Docs have been added / updated (for bug fixes / features)
Sample in sample app has been added / updated (for bug fixes / features)
Tests for the changes have been added (for bug fixes / features) (if applicable)

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Namespaces for Parser elements change from Microsoft.Toolkit.Uwp.UI.Controls to Microsoft.Toolkit.Services.Markdown. This shouldn't matter too much, since most of this was marked as Internal anyways.
A lot of Internal Parsing Classes had to be made Public, as they are involved in creating the UI in the MarkdownTextblock, and any other Control based off of the Parser. It appears it was all documented anyway, but it increases the API surface.
Some RSS Parser and classes moved and changed namespaces, this is mostly fine, but there might need to be some deprecation warnings.

Other information

I am using this to create an Xamarin Android Markdown TextView, If I create that, I'm more than happy to add it to a future Microsoft.Toolkit.Android.UI.Controls Project :)

This would have to become the Microsoft Community Toolkit though.

-Made required Parsing Classes and Enums public (I know I could have done InternalsVisibleTo, but then the Parser wouldn't be extensible. -Moved Parser to Microsoft.Toolkit.Services, seemed most relevant, but could be moved elsewhere.

-Moved DependecyProperties to top of definition. -Referenced Parser in documentation.

…atform rendering base class. This might need tweaks as it is almost a direct Port of XamlRenderer. -Broke down XamlRenderer and MarkdownRendererBase into partial classes for Blocks and Inline, as well as Properties.

… Xaml, and the name is easier to understand.

-Moved Superscript methods out of MarkdownRendererBase back to UWPMarkdownRenderer, as they are fixes for a UWP implementation. -Created CheckRenderMarkdownLink, split off of UWPMarkdownRenderer RenderMarkdownLink, it validates links before creation.

…t custom formatting into a Code Block, such as adding Syntax Highlighting.

WilliamABradley · 2017-11-27T03:26:13Z

@nmetulev I was thinking of adding Syntax Highlighting to the Code Blocks, (Using GitHub Style Prefixing of the block) e.g.

```c#
public void Method()
{
}
```

makes

public void Method()
{
}

I found a library that could do it, at https://colorcode.codeplex.com/ which I could modify to use Spans for RichTextBlock, and SpannableStrings for Android (Using an interface or abstract class).

I'm not sure how the license is compatible, it is a Microsoft Public License.

I have added an Event to Handle processing Code Block Syntax rendering, would we want to roll built in Syntax Highlighting?

…e inline with Presentation in Reddit and Github, in terms of color choice and Quote styling. -Inline Code elements are now much easier to see, they have a border, and customisable padding. These elements are customised separately from the Code Blocks. This is because they generally follow the current line's properties, such as formatting and font family. They having customisable paddings, border brushes, border thicknesses, background color and font family. They used to only be a different font family. -Prefixed Code Blocks now correctly collect the Programming Language Identifier. This Identifier is no longer rendered to the screen. -Separated the measurement based properties into a new .Dimensions.cs partial file for UWPMarkdownRenderer and MarkdownTextBlock. -Added some properties to the MarkdownTextBlock sample page, also added a demo CodeBlockResolveingEvent, for custom Syntax Highlighting.

WilliamABradley · 2017-11-27T14:10:22Z

I have made some much needed style changes to the default Markdown Style for the Markdown TextBlock.
This style is more aesthetically pleasing, and more closely resembles the styles used in Reddit and Github, in terms of Quote Style, and Code Formatting.

I also rebuilt the Code Inlines, so that they now are more than just a different font family, but actually have a Border, Background, etc.

This should become the default style, but a Compat Style could be provided to anyone who wants to update to this version and keep their old styling, for some reason.

…ide a inherited IRenderContext interface. This is because these parameters are UWP Specific. IRenderContext provides a useful container for the contract, holding the UI State.

michael-hawker · 2017-11-28T06:41:13Z

@WilliamABradley wow, cool! I'll start reviewing this.

I was just needing to do some Markdown parsing on a personal project and thought it'd be great if we could break this parser out. I wanted to look at some extensions for RichEditBox accepting/returning some basic Markdown, so I think this is a step towards that as well.

…as done with a new Reference to WilliamABradley/ColorCode-Universal which is a fork from the old ColorCode Codeplex project, with a new RichTextBlockFormatter. -Fixed some Render Context structures. -Added some documentation for the new Properties and Events.

WilliamABradley · 2017-11-28T08:57:46Z

@michael-hawker @nmetulev I have added built in Syntax Highlighting!

Isn't it glorious! Unfortunately there are some missing formats, and things I would like to tweak from ColorCode-Universal, such as the fact that XAML isn't recognised (but xml is), C# Method and Property coloring, etc.

Since I ported the Library in my personal GitHub, and upgraded it there, there are no license conflicts with the UWP Community Toolkit.

Also, @michael-hawker, if you take a look at https://github.com/WilliamABradley/ColorCode-Universal, you could use ColorCode.UWP to make a RichEditBox with Syntax Highlighting, such as a possible RichEditBoxFormatter, if that is something you want on your personal project. (We could make a MarkdownEditBox, and leverage the Markdown formatting in ColorCode-Universal to assist writing markdown with Syntax Highlighting, much like Visual Studio and VS Code does).

*Also, I will update all .md files in the documentation with Language prefixed Code Blocks, so that we get Syntax Highlighting in the documentation.

WilliamABradley · 2017-11-28T09:10:08Z

Also Text Selection is a real mess right now and pretty broken (Before this PR too), I think it could be possible to make the Text Selection work across the different internal controls. Perhaps it could be done in a separate PR, but it just isn't there right now. Should we leave text selection off by default?

nmetulev

This is amazing, definitely a great idea. Biggest change I'd request right now is regarding where the code sits. Microsoft.Toolkit.Services is not the right place for the parser. That package is for services such as Twitter and Facebook. Please create a new project to host the parser. How about Microsoft.Toolkit.Markdown?

nmetulev · 2017-12-04T04:24:02Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/MarkdownTextBlock/InitialContent.md

        System.out.println("Hello world!");
    }

 Starting with UWP Community Toolkit v1.4, you can also use GitHub code notification by creating a block surrounded by 3x\` (3 backticks). So:


Need to rewrite this sentence so the So at the end makes sense

nmetulev · 2017-12-04T04:31:42Z

Microsoft.Toolkit.Uwp.UI.Controls/MarkdownTextBlock/MarkdownRenderedEventArgs.cs

    /// rendered.
    /// </summary>
+    [Obsolete("Use Microsoft.Toolkit.Services.Markdown.MarkdownRenderedEventArgs instead.")]
    public class MarkdownRenderedEventArgs : EventArgs


This class should just extend the new class. Wouldn't the new class require developers to include the new package as well in order to use the event?

nmetulev · 2017-12-04T04:44:51Z

Microsoft.Toolkit.Uwp.UI.Controls/MarkdownTextBlock/MarkdownTextBlock.xaml

+            <SolidColorBrush x:Key="MarkdownInlineCodeBackgroundBrush" Color="#FFDDDFE1" />
+            <SolidColorBrush x:Key="MarkdownQuoteForeground" Color="#FF6E747C" />
        </ResourceDictionary>
        <ResourceDictionary x:Key="Dark">


The Dark theme seems broken?

You have to set the Foreground color in the Properties Panel, when switching to Dark mode, as it allows you to change it.

WilliamABradley · 2017-12-04T04:53:28Z

@nmetulev I was thinking that, however, there is an RSS Parser in the same folder, although that doesn't interact with UI, so I can go that if you want?

nmetulev · 2017-12-04T05:02:12Z

Yeah, the RSS parser is internal because it's needed by the bing service. We should probably move it to the same project as the markdown parser and make it public.

WilliamABradley · 2017-12-04T05:04:38Z

@nmetulev Awesome, I can get on with that, making Microsoft.Toolkit.Parsers?

Also, should I replace the Sample App's Async Code Coloring Code Panel, with a call to ColorCode-Universal RichTextBlockFormatter, which isn't asynchronous?

nmetulev · 2017-12-04T05:07:49Z

Microsoft.Toolkit.Parsers sounds good

What's the benefit of replacing the call with one that's not asynchronous?

WilliamABradley · 2017-12-04T05:13:26Z

ColorCode-Universal uses regex and produces HTML, or a Colorized RichTextBlock (So its native), and it has greater support for a larger set of languages.

The current implementation uses a WebView and JavaScript, so it takes longer to load, and doesn't support theme styling, etc.
It also doesn't seem to support as much of each language definition.

nmetulev · 2017-12-04T05:15:36Z

Ah, I see what you mean. Sounds good, go for it.

…ect. -Made RSS Parser and it's types public. -Added CodeStyling property to MarkDownTextBlock for the built in Syntax Highlighter. -Added Build.bat for one-click simplicity.

nmetulev · 2018-02-06T03:55:19Z

docs/controls/MarkdownTextBlock.md

+block.SetRenderer<InheritedUWPMarkdownRenderer>();
+```
+
+This might require intimate knowledge of the implementation of the `UWPMarkdownRenderer`, take a look at the following:


Change name to MarkdownRenderer

@nmetulev Done.

… to make it easier to follow along. -Improved the DocFX note style, bringing it even more in-line with docs.microsoft.com.

michael-hawker

GitHub stopped loading diffs for me, so I'll take a look at the other changes a bit later. Some initial small comments though from what I played with on the weekend.

michael-hawker · 2018-02-06T05:23:04Z

Microsoft.Toolkit.Parsers/Core/SchemaBase.cs

+namespace Microsoft.Toolkit.Parsers
+{
+    /// <summary>
+    /// Strong typed schema base class.


Could be handy to have more details here on what this is used for.

It is used by the RSS Parser, and some of the Services like Bing? It is a base class for Schema based parsers.

michael-hawker · 2018-02-06T05:24:02Z

Microsoft.Toolkit.Parsers/Core/StringValueAttribute.cs

+namespace Microsoft.Toolkit.Parsers.Core
+{
+    /// <summary>
+    /// StringValue attribute.


StringValue attribute used by...? extra pointers would be helpful here.

It is used by the Bing Service, I believe.

It looks like it's an enum helper. Could be nice to elaborate the description here to The StringValue attribute is used as a helper to decorate enum values with string representations. Though I don't see where Bing actually reads these in...

Are we removing the old one in Microsoft.Toolkit.Uwp.Services as part of this change?

michael-hawker · 2018-02-06T05:28:40Z

Microsoft.Toolkit.Parsers/Markdown/Enums/InlineParseMethod.cs

+
+namespace Microsoft.Toolkit.Parsers.Markdown.Enums
+{
+    internal enum InlineParseMethod


How is this different than MarkdownInlineType?

InlineParseMethod is used for identifying Inlines with TripChars, the other is for structure identification.
An inline type might have no MarkdownInlineType, private Inlines like BoldItalicInline which converts itself into a BoldInline, it is a workaround.

This stuff has always been here, I might clean it up / remove it in a new PR (Like with #1767 where I will likely remove the enums altogether).

michael-hawker · 2018-02-06T05:32:53Z

Microsoft.Toolkit.Parsers/Markdown/Helpers/LineInfo.cs

+
+namespace Microsoft.Toolkit.Parsers.Markdown.Helpers
+{
+    internal class LineInfo


Is this for tracking block positions?

If so, could be useful to expose for locating/highlighting text based on parsing?

Again, this should be work for a PR based #1767, where we open up the internals of the Parser for tinkering.

Since you couldn't really do much with this info right now, and it would require considerable more work to expose, leave it for now.

This PR is big enough as it is :)

michael-hawker · 2018-02-06T05:33:23Z

Microsoft.Toolkit.Parsers/Markdown/Inlines/BoldItalicTextInline.cs

            }

-            if (markdown == null || markdown.Length < 6)
+            if (markdown == null || markdown.Length < 6 || start + 6 >= maxEnd)


What's the '6' for?

It ensures that the length of the string can possibly fit two sets of "***", which is required for Bold and Italic parsing. Without these, creating a BoldItalicInline will crash if prepended or appended to the text, due to the substring calls.

michael-hawker · 2018-02-06T05:40:33Z

Microsoft.Toolkit.Parsers/Markdown/MarkdownDocument.cs

                return base.ToString();
            }

            return string.Join("\r\n", Blocks);


Might not have gotten to it yet. Is there a test that checks that the output of the MarkdownDocument toString is the same as what was passed in to Parse?

No, that code was before my PR :)

Might be good to think about adding another test then that has a sample markdown text blob, gets read by the parser, and then the document gets serialized back to markdown and compare the results?

There are numerous cases where this isn't done, or the returned ToString isn't the same is the input. Examples are the CodeBlock where it just returns the text. HorizontalRuleBlock only returns one kind of raw line, when there are several ways to do it, etc.

It could be done, but it would take some considerable reworking, possibly for a future PR like #1767 or future PRs.

michael-hawker · 2018-02-06T05:43:28Z

Microsoft.Toolkit.Parsers/Markdown/MarkdownElement.cs

    /// </summary>
-    internal abstract class MarkdownElement
+    public abstract class MarkdownElement
    {


Is there another block type we could use here on all elements? Trying to think if that'd be nicer than having to check class instances.

Also wondering if we want a common 'Text' property or if toString is sufficient. Or maybe 'DisplayText' which would have the text without the markup?

Currently the Text Property belongs to IInlineLeaf, as not all Inlines have text. And Blocks (Which inherit from MarkdownElement) definitely don't have a text property.

Unfortunately, Blocks aren't guaranteed to have Inlines or text either, so it makes it difficult to traverse the structure manually.

You would have to check the type using is or looking at the MarkdownBlock.Type and MarkdownInline.Type properties.

The way I would do it is:

switch(block) { case CodeBlock code: var text = code.Text; ... }

michael-hawker · 2018-02-06T05:45:51Z

Microsoft.Toolkit.Parsers/Rss/AtomParser.cs


-namespace Microsoft.Toolkit.Services.Rss


Was this internal usage before too?

michael-hawker · 2018-02-06T05:47:39Z

Microsoft.Toolkit.Uwp.SampleApp/Controls/SampleAppMarkdownRenderer.cs

+            {
+                case "CSHARP":
+                case "CS":
+                    language = "C#";


Should this not be in the parser somewhere vs the renderer?

This is just for the header of the Sample App's Code Block that has a header specifying the language of the Code, just like docs.microsoft.com.

michael-hawker · 2018-02-06T05:48:57Z

Microsoft.Toolkit.Uwp.SampleApp/Controls/SampleAppMarkdownRenderer.cs

+            }
+        }
+
+        private const string NoteGlyph = "\uE946";


Should this be configurable? Or is it part of the Common Mark spec?

This is only for the Sample App, it is part of DocFX, so it isn't included in our CommonMark-ish parser.

…lkit into MakeMarkdownUniversalAgain

…ting name, and avoids naming confusion with LinkReferenceBlock.

…rsalAgain.

WilliamABradley · 2018-02-12T19:50:49Z

ping @nmetulev All dependent PRs are now merged :)

nmetulev

Looks good to me. Make sure to pull latest.

michael-hawker

Think that's the last of it, finally got the whole thing to load. Phew...

michael-hawker · 2018-02-13T04:23:19Z

Microsoft.Toolkit.Parsers/Core/ExtensionMethods.cs

+        /// <summary>
+        /// Regular expression of HTML tags to remove.
+        /// </summary>
+        private static readonly Regex RemoveHtmlTagsRegex = new Regex(@"(?></?\w+)(?>(?:[^>'""]+|'[^']*'|""[^""]*"")*)>");


Put all these methods in the new StringExtensions?

michael-hawker · 2018-02-13T04:30:03Z

Microsoft.Toolkit.Parsers/Core/StringValueAttribute.cs

+namespace Microsoft.Toolkit.Parsers.Core
+{
+    /// <summary>
+    /// StringValue attribute.


It looks like it's an enum helper. Could be nice to elaborate the description here to The StringValue attribute is used as a helper to decorate enum values with string representations. Though I don't see where Bing actually reads these in...

Are we removing the old one in Microsoft.Toolkit.Uwp.Services as part of this change?

michael-hawker · 2018-02-13T04:34:24Z

Microsoft.Toolkit.Parsers/Markdown/Blocks/ListBlock.cs


+            if (newLine)
+            {
+                builder.Append("\n");


Are we using \n everywhere, are there cases where we should be using Environment.NewLine?

michael-hawker · 2018-02-13T04:38:20Z

Microsoft.Toolkit.Parsers/Markdown/Blocks/ListBlock.cs

                switch (Style)
                {
                    case ListStyle.Bulleted:
                        result.Append("* ");


Is there a reason you add the space after the bullet here, but not after the '.' below? I'd assume we'd want a space after in both cases to be consistent?

It was a pre-existing implementation.

michael-hawker · 2018-02-13T04:40:07Z

Microsoft.Toolkit.Parsers/Markdown/Enums/ListStyle.cs

@@ -10,26 +10,21 @@
 // THE CODE OR THE USE OR OTHER DEALINGS IN THE CODE.
 // ******************************************************************

-namespace Microsoft.Toolkit.Uwp.Services.Rss


??? This seems like an odd rename?

Git got a little confused.

michael-hawker · 2018-02-13T05:32:28Z

Microsoft.Toolkit.Uwp.UI.Controls/MarkdownTextBlock/Render/MarkdownRenderer.Inlines.cs

+
+            var border = new Border
+            {
+                Padding = new Thickness(0, 0, 0, paragraph.FontSize * 0.2),


Magic Number?

I didn't change anything here, it was moved.

As discussed offline, was here before, we can worry about another day.

This was an existing implementation.

michael-hawker · 2018-02-13T05:34:59Z

UWP Community Toolkit.sln

 	EndProjectSection
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Toolkit.Uwp.Notifications.JavaScript", "Microsoft.Toolkit.Uwp.Notifications.JavaScript\Microsoft.Toolkit.Uwp.Notifications.JavaScript.csproj", "{94F8D702-3A9D-4CFB-85C9-79FC5DBD8B22}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Toolkit.Uwp.Notifications.JavaScript", "Microsoft.Toolkit.Uwp.Notifications.JavaScript\Microsoft.Toolkit.Uwp.Notifications.JavaScript.csproj", "{94F8D702-3A9D-4CFB-85C9-79FC5DBD8B22}"


Do we know why this guid changed?

No idea? Perhaps pulling master?

michael-hawker · 2018-02-13T05:40:26Z

docs/controls/WrapPanel.md

-      xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
-      xmlns:wrapPanel="using:Microsoft.Toolkit.Uwp.UI.Controls.WrapPanel"
-      mc:Ignorable="d">
+    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"


Lots of whitespace changes, these don't lineup anymore. :(

It was Visual Studio, It is probably better because that means these will take less horizontal space.

I just like my xaml attributes to line up, but maybe I'm weird that way...

It would a major pain to fix all of the code comments :(

michael-hawker · 2018-02-13T05:43:33Z

UnitTests/Markdown/Parse/BoldTests.cs

+using Microsoft.Toolkit.Parsers.Markdown.Blocks;
+using Microsoft.Toolkit.Parsers.Markdown.Inlines;

 namespace UnitTests.Markdown.Parse


Should there be a new bold+italic test suite?

As mentioned we can resolve in #1798.

michael-hawker · 2018-02-13T05:44:34Z

UnitTests/UnitTests.csproj

    <Content Include="Assets\StoreLogo.png" />
    <Content Include="Assets\Wide310x150Logo.scale-200.png" />
  </ItemGroup>
  <ItemGroup>


We should add a code block test since its new. Anything else new?

The original Code Block test still works.

-Gave StringValueAttribute a better description. -Added OrdinalIgnoreCase to Common.IndexOf. -Fixed general feedback.

…lkit into MakeMarkdownUniversalAgain

WilliamABradley · 2018-02-13T07:52:09Z

@michael-hawker Made all changes against review.

michael-hawker

Pretty close, for the Code Block unit test, I meant adding for parsing out the language name.

michael-hawker · 2018-02-13T20:35:11Z

Microsoft.Toolkit/Extensions/StringExtensions.cs

+        /// <summary>
+        /// Regular expression for removing comments.
+        /// </summary>
+        private static readonly Regex RemoveCommentsRegex = new Regex("<!--.*?-->", RegexOptions.Singleline);


Should preface these as Html comments/scripts/styles, eh?

michael-hawker · 2018-02-13T20:37:21Z

Microsoft.Toolkit/Extensions/StringExtensions.cs

+        }
+
+        /// <summary>
+        /// Truncates the specified string to the specified length.


Should mention it trims too.

…#1650 merging.

-Added Backtick and Code language tests for Code Block.

WilliamABradley · 2018-02-14T01:15:22Z

@michael-hawker I performed the requested changes.

michael-hawker

Yay!

WilliamABradley added 9 commits November 26, 2017 18:13

-Split the Markdown Parser from MarkdownTextBlock.

00f9e98

-Made required Parsing Classes and Enums public (I know I could have done InternalsVisibleTo, but then the Parser wouldn't be extensible. -Moved Parser to Microsoft.Toolkit.Services, seemed most relevant, but could be moved elsewhere.

Made old MarkdownRenderedEventArgs obsolete.

1e1600b

-Broke MarkdownTextBlock.cs into Categorised partial sections.

f68fec8

-Moved DependecyProperties to top of definition. -Referenced Parser in documentation.

Fixed Header.

75ff445

Renamed XamlRenderer to UWPMarkdownRenderer, as it doesn't Render any…

9650653

… Xaml, and the name is easier to understand.

Fixed missing Headers.

b2d1385

Added ICodeBlockResolver and CodeBlockResolving event, a way to injec…

2f34ae2

…t custom formatting into a Code Block, such as adding Syntax Highlighting.

WilliamABradley added 2 commits November 27, 2017 16:54

Fixed XML Comment, warned that Resolving events require Handled = true.

812e9e9

Moved BlockUIElementCollection object and InlineCollection ojbect ins…

7d6140c

…ide a inherited IRenderContext interface. This is because these parameters are UWP Specific. IRenderContext provides a useful container for the contract, holding the UI State.

WilliamABradley changed the title ~~Move the Markdown Parser to .NET Standard~~ Markdown Parser for .NET Standard, MarkdownTextBlock Style Improvements, Syntax Highlighting Dec 2, 2017

nmetulev reviewed Dec 4, 2017

View reviewed changes

WilliamABradley added 2 commits December 5, 2017 22:22

-Moved Markdown and RSS Parsers to new Microsoft.Toolkit.Parsers proj…

7b5c53f

…ect. -Made RSS Parser and it's types public. -Added CodeStyling property to MarkDownTextBlock for the built in Syntax Highlighter. -Added Build.bat for one-click simplicity.

Merge branch 'master' into MakeMarkdownUniversalAgain

f133914

WilliamABradley mentioned this pull request Dec 5, 2017

Microsoft Community Toolkit > UWP Community Toolkit #1681

Closed

Fixed Namespace change issues.

0ff9bc1

nmetulev reviewed Feb 6, 2018

View reviewed changes

WilliamABradley added 2 commits February 6, 2018 17:08

Fixed naming conventions and locations for Markdown Docs.

2d2bf1d

-Simplified SampleAppMarkdownRenderer structure, added extra comments…

b4b1dec

… to make it easier to follow along. -Improved the DocFX note style, bringing it even more in-line with docs.microsoft.com.

michael-hawker reviewed Feb 6, 2018

View reviewed changes

WilliamABradley added 2 commits February 7, 2018 12:46

Merge branch 'master' of https://github.com/Microsoft/UWPCommunityToo…

02155bd

…lkit into MakeMarkdownUniversalAgain

Fixed VS complaints.

8e320fa

michael-hawker mentioned this pull request Feb 10, 2018

MarkdownTextBlock doesn't support '***' for bold+italic #1798

Closed

WilliamABradley mentioned this pull request Feb 10, 2018

Sample App Fluent Design & Dark Theme #1755

Merged

3 tasks

WilliamABradley added 5 commits February 11, 2018 12:24

Merge branch 'master' of https://github.com/Microsoft/UWPCommunityToo…

d5911c4

…lkit into MakeMarkdownUniversalAgain

Renamed LinkReferenceInline to LinkAnchorInline, as it is a more fit…

dca5553

…ting name, and avoids naming confusion with LinkReferenceBlock.

Fixed more VS complaints.

d078053

Merged changes from UWPCommunityToolkit/Master into MakeMarkdownUnive…

3212cb6

…rsalAgain.

Merged UWPCommunityToolkit/Master into MakeMarkdownUniversalAgain.

2c96d80

nmetulev approved these changes Feb 13, 2018

View reviewed changes

michael-hawker requested changes Feb 13, 2018

View reviewed changes

WilliamABradley added 3 commits February 13, 2018 19:56

-Moved Extension methods to StringExtensions.

3137573

-Gave StringValueAttribute a better description. -Added OrdinalIgnoreCase to Common.IndexOf. -Fixed general feedback.

Merge branch 'master' of https://github.com/Microsoft/UWPCommunityToo…

929121e

…lkit into MakeMarkdownUniversalAgain

Fixed some more things.

36fb178

michael-hawker requested changes Feb 13, 2018

View reviewed changes

WilliamABradley added a commit to WilliamABradley/WindowsCommunityToolkit that referenced this pull request Feb 14, 2018

Added ThemeListener to Sample JSON in prepartion for CommunityToolkit…

4a432e8

…#1650 merging.

WilliamABradley added 2 commits February 14, 2018 14:12

-Fixed naming and descriptions of StringExtensions.

f4901eb

-Added Backtick and Code language tests for Code Block.

-Added tests to MD test playlist.

5faa708

michael-hawker approved these changes Feb 14, 2018

View reviewed changes

WilliamABradley merged commit 70717f8 into CommunityToolkit:master Feb 14, 2018

WilliamABradley deleted the MakeMarkdownUniversalAgain branch February 14, 2018 01:23

This was referenced Feb 14, 2018

Implementing Tapped on Images in MarkdownTextBlock #1807

Merged

Docs update #1748

Merged

Uh oh!

Markdown + RSS Parser for .NET Standard, MarkdownTextBlock Style Improvements, Syntax Highlighting #1650

Markdown + RSS Parser for .NET Standard, MarkdownTextBlock Style Improvements, Syntax Highlighting #1650

Uh oh!

Conversation

WilliamABradley commented Nov 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

PR Checklist

Does this PR introduce a breaking change?

Other information

Uh oh!

WilliamABradley commented Nov 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WilliamABradley commented Nov 27, 2017

Uh oh!

michael-hawker commented Nov 28, 2017

Uh oh!

WilliamABradley commented Nov 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WilliamABradley commented Nov 28, 2017

Uh oh!

nmetulev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WilliamABradley commented Dec 4, 2017

Uh oh!

nmetulev commented Dec 4, 2017

Uh oh!

WilliamABradley commented Dec 4, 2017

Uh oh!

nmetulev commented Dec 4, 2017

Uh oh!

WilliamABradley commented Dec 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nmetulev commented Dec 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-hawker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WilliamABradley Feb 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

WilliamABradley commented Nov 26, 2017 •

edited

Loading

WilliamABradley commented Nov 27, 2017 •

edited

Loading

WilliamABradley commented Nov 28, 2017 •

edited

Loading

WilliamABradley commented Dec 4, 2017 •

edited

Loading

WilliamABradley Feb 6, 2018 •

edited

Loading

WilliamABradley Feb 6, 2018 •

edited

Loading