TextToolbar for RichEditBox #1109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipped Image. -Moved shared ImageEx Logic to ImageEx base. -RoundImageEx has Properties to add Stroke, StrokeThickness and the ability to disable Stroke on Placeholder Images. -Added RoundImageEx to ImageEx Sample Page.
-Removed Unused Usings.
-Moved Stroke Visual State Strings to RoundImageEx. -Attached PlaceholderSourceChanged (Woops) and removed SetSource as it was copied from ImageEx.Source. -ShowStroke Visual State doesn't seem to work, testing the Stroke animation with EnableDependentAnimation works on the CommonStates, but not in StrokeStates, so I am temporarily setting StrokeThickness binding (ShowPlaceholderStroke does nothting).
…t properties now work. -Modified coding formatting to adhere to Style requests. -Fixed missing Bracket.
-Created basic Sample Page. -Current Issues: *Can’t seem to register Commands into the Shell for sample page. *Code formatting hasn’t been implemented properly yet, inlines don’t seem to be to spec for MarkDownTextBlock? Code blocks hasn’t been implemented either. *Setting a List from a selection that starts in the middle of a line confuses the SetList Function, and places the LineChar at the end of the first line. *Different Formatting types would likely want different Default Buttons, perhaps a way to Replace all Default Buttons in XAML without requiring a complete restyle? *RichTextFormatter is unimplemented. *If you remove a Default Button, you can’t add it back. *There is currently a dependency on the FontAwesome Font, as MDL2 has not NumberedList Icon. *Replacing the Default Labels for translation is a bit daunting, is there a better way? *Would it be helpful if the SetSelect and SetList functions were moved out of MarkDownFormatter for use in other formatters?
|
@WilliamABradley, |
-Default Button layout is now defined by the Formatter Class. -CustomToolbarButtons and Default Buttons now use the ToolbarButton and Separator Templated Control. -The User can now Set Custom Toolbar Items and remove Default Toolbar Items from XAML. -Designer Update not Working, need to reload the page for changes to buttons to show up. -Default button events are now easier to assign as a result. ==================== -Removed Hardcoded Resouce Dictionary Entry for ToolbarButton and Separator Styles. -Moved Format Enum to its own file in Formats. -Added licenses. -Code and Quote Formatting are no longer required in the Formatter as they are MarkDown Specific. Does the formatter need any of these Methods? What about e.g. HTMLTextToolbar? -Marked MarkDown methods as Virtual so they can be overwritten, for different Markdown Variants.
…of Selected Text, instead of adding it to the end. End of Selection is only applied if there is now selected text. -Fixed Access Modifiers for CommonButtons.Events
-Did I solve the problem or dig myself a bigger hole?
This was referenced Apr 21, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason GitHub wouldn't let me Pull this Request without the modified code from my RoundImageEx at #1100. (I'm still a GitHub/Git noob). The last commit is the one with the TextToolbar.*Fixed
TextToolbar w/ MarkDown & RichText Support from Markdown Text Editor #1107.
Current Issues:
Can’t seem to register Commands into the Shell for sample page.
Code formatting hasn’t been implemented properly yet, inlines don’t seem to be to spec for MarkDownTextBlock? Code blocks hasn’t been implemented either.
Setting a List from a selection that starts in the middle of a line confuses the SetList Function, and places the LineChar at the end of the first line.
Different Formatting types would likely want different Default Buttons, perhaps a way to Replace all Default Buttons in XAML without requiring a complete restyle?
RichTextFormatter is unimplemented (Someone else can write it).
If you remove a Default Button, you can’t add it back.
There is currently a dependency on the FontAwesome Font, as MDL2 has not NumberedList Icon.
Replacing the Default Labels for translation is a bit daunting, is there a better way?*Probably easier, at the cost of Code mess.
Would it be helpful if the SetSelect and SetList functions were moved out of MarkDownFormatter for use in other formatters?
Fix Designer so that adding Custom Buttons / Removing Default Buttons updates the Designer.