-
Couldn't load subscription status.
- Fork 1.4k
Closed
Labels
Completed 🔥bug 🐛An unexpected issue that highlights incorrect behaviorAn unexpected issue that highlights incorrect behaviorcontrols 🎛️optimization ☄Performance or memory usage improvementsPerformance or memory usage improvements
Milestone
Description
Describe the bug
Follow-on from #4456
- Noticed the event handlers are only getting cleaned up in the Unloaded event instead of OnApplyTemplate before new ones are registered.
- Since the Keyboard accelerators don't rely on a template piece, we can register in constructor/loaded event.
- we can make lambda's static as https://learn.microsoft.com/uwp/api/windows.ui.xaml.input.keyboardacceleratorinvokedeventargs should contain
Elementto access/set property values.
Regression
No response
Reproducible in sample app?
- This bug can be reproduced in the sample app.
Steps to reproduce
N/A
Expected behavior
Not duplicate event registration
Screenshots
No response
Windows Build Number
- Windows 10 1809 (Build 17763)
- Windows 10 1903 (Build 18362)
- Windows 10 1909 (Build 18363)
- Windows 10 2004 (Build 19041)
- Windows 10 20H2 (Build 19042)
- Windows 10 21H1 (Build 19043)
- Windows 11 21H2 (Build 22000)
- Other (specify)
Other Windows Build number
No response
App minimum and target SDK version
- Windows 10, version 1809 (Build 17763)
- Windows 10, version 1903 (Build 18362)
- Windows 10, version 1909 (Build 18363)
- Windows 10, version 2004 (Build 19041)
- Other (specify)
Other SDK version
No response
Visual Studio Version
No response
Visual Studio Build Number
No response
Device form factor
No response
Nuget packages
No response
Additional context
No response
Help us help you
Yes, I'd like to be assigned to work on this item.
Metadata
Metadata
Assignees
Labels
Completed 🔥bug 🐛An unexpected issue that highlights incorrect behaviorAn unexpected issue that highlights incorrect behaviorcontrols 🎛️optimization ☄Performance or memory usage improvementsPerformance or memory usage improvements
Type
Projects
Status
Done