Skip to content

[Feature] Ensure all controls have style names #3602

@michael-hawker

Description

@michael-hawker

Follow-on from microsoft/microsoft-ui-xaml#3735

Describe the problem this feature would solve

Over time in the toolkit we've been better at adopting better practices around making our styles. We should ensure that we go back and retroactively apply these to other older controls. 7.0 would be a good time to do this...

Describe the solution

Update Styles of controls to ensure that the base style is named and available. (though we may have another issue where these aren't getting exposed to the application level, see: #3556 (comment))

We also generally split out the ControlTemplate as well:

<Style TargetType="ControlName" BasedOn="DefaultControlNameStyle"/>

<Style x:Key="DefaultControlNameStyle" TargetType="ControlName">
    ...
    <Setter Property="Template" Value="{StaticResource DefaultControlTemplate}" />
</Style>

<ControlTemplate x:Key="DefaultControlTemplate" ...

Metadata

Metadata

Assignees

No one assigned

    Labels

    HacktoberfestHacktoberfest is a month-long celebration of open source softwarefeature request 📬A request for new changes to improve functionalitygood first issueIssues identified as good for first-time contributorsimprovements ✨

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions