[Question] Contribute Behaviors to main XAML Behaviors packages?

[michael-hawker]

@brianlagunas @pedrolamas we have some behaviors we're shipping in the toolkit (as well as a helper to make creating some types of behaviors that rely on UI loading easier).

Would it make sense to instead contribute these back directly to the behaviors repo? What are your thoughts here?

[brianlagunas]

It depends on the behaviors you are wanting to add. Obviously they can't be behaviors specific to a particular implementation, feature, or framework.

[pedrolamas]

I agree with Brian, my view is that this should be seen on a case by case to assess the added value of any new behavior.

[michael-hawker]

We're adding a Microsoft.Toolkit.Uwp.UI.Behaviors package to this release, so let's see how that goes, and if there's anything in there that you too think would make a good candidate for the root package, we can discuss moving things over?

I think the biggest thing I see us using in the Toolkit which could be helpful in the base is the additional helper we do if you need to wait for the AssociatedObject to load and hook into its Loaded event in our BaseBehavior.

Maybe we should open a feature request on the Behaviors package for that?

For now, I think I'll close this issue?

Thoughts @pedrolamas @brianlagunas?

[pedrolamas]

I might have misunderstood your comments above, but my personal view is that the Loaded/Unloaded of the associated object should be handled only by the attached/detached methods only, thus making things simpler and cleaner.

We've seen memory leaks in the past due to mishandling of this.

I'm ok with closing this.

[michael-hawker]

@pedrolamas I was talking about the extra stuff we do in BehaviorBase here. Seems like some of the underlying issues may have been resolved. I can open a general issue for this particular facet on the Behavior repo. Thanks!

Closing this for now.