Declared SupportedOSPlatformVersion for WinAppSdk - #206
Merged
Conversation
Arlodotexe
added a commit
to CommunityToolkit/Windows
that referenced
this pull request
Aug 20, 2024
declared SupportedOSPlatformVersion for WinAppSdk. See CommunityToolkit/Tooling-Windows-Submodule#206 (comment)
Member
Author
|
@michael-hawker do we still want to merge this for posterity? |
michael-hawker
approved these changes
Aug 22, 2024
Member
Member
Author
For posterity, to avoid this kind of confusion in the future. |
Member
|
But that confirms what I'm saying: you can just set |
Member
Author
|
We did, but the fact that it changed caused the confusion to start with. Docs don't specify anywhere that it's optional if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Background
For net5.0+ targets, TargetPlatformMinVersion was renamed to SupportedOSPlatformVersion. See dotnet/designs#157
The dotnet SDK uses the TargetPlatformVersion property to provide a default SupportedOSPlatformVersion value if none is explicitly provided. See https://github.com/dotnet/designs/blob/bba3216250cb29b0063bac3ebb57a542ee21ad4f/accepted/2020/minimum-os-version/minimum-os-version.md?plain=1#L73C27-L73C48.
Overview
SupportedOSPlatformVersion, using the existingTargetPlatformMinVersionvalue.Fixes an issue where apps using the toolkit were no longer able to run on versions lower than 19041 (see here).Windows 10 Version 1809 Build 17763andWindows 10 Version 21H1 Build 19043to test the RC packages, I'm not seeing any issues building and deploying in a blank WinUI 3 app.